mbox series

[git,pull] sendfile fixes

Message ID YCk/f0efY5OhibCn@zeniv-ca.linux.org.uk (mailing list archive)
State New
Headers show
Series [git,pull] sendfile fixes | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.sendfile

Message

Al Viro Feb. 14, 2021, 3:19 p.m. UTC
Making sendfile() to pipe destination do the right thing, should
make "fs/pipe: allow sendfile() to pipe again" redundant.  Sat in -next
for 3 weeks...

The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e:

  Linux 5.11-rc1 (2020-12-27 15:30:22 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.sendfile

for you to fetch changes up to b964bf53e540262f2d12672b3cca10842c0172e7:

  teach sendfile(2) to handle send-to-pipe directly (2021-01-25 23:29:36 -0500)

----------------------------------------------------------------
Al Viro (3):
      do_splice_to(): move the logics for limiting the read length in
      take the guts of file-to-pipe splice into a helper function
      teach sendfile(2) to handle send-to-pipe directly

 fs/internal.h   |  9 +++++++++
 fs/read_write.c | 19 +++++++++++++------
 fs/splice.c     | 44 ++++++++++++++++++++++++--------------------
 3 files changed, 46 insertions(+), 26 deletions(-)

Comments

Linus Torvalds Feb. 14, 2021, 7:35 p.m. UTC | #1
On Sun, Feb 14, 2021 at 7:19 AM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
>         Making sendfile() to pipe destination do the right thing, should
> make "fs/pipe: allow sendfile() to pipe again" redundant.  Sat in -next
> for 3 weeks...

Just to clarify: this says "fixes", but I get the feeling that you
meant for me to pull tomorrow in the 5.12 merge window?

I like the patches, but they don't seem to be anything hugely urgent.
They should make "sendfile to pipe" more efficient, but the current
hack is _workable_ (and not any worse than what we historically did)
even if it's not optimal.

Right?

Oh, and it looks like the first line of the commit message of
313d64a35d36 ("do_splice_to(): move the logics for limiting the read
length in") got truncated somehow..

          Linus
Al Viro Feb. 14, 2021, 9:18 p.m. UTC | #2
On Sun, Feb 14, 2021 at 11:35:36AM -0800, Linus Torvalds wrote:

> Just to clarify: this says "fixes", but I get the feeling that you
> meant for me to pull tomorrow in the 5.12 merge window?
> 
> I like the patches, but they don't seem to be anything hugely urgent.
> They should make "sendfile to pipe" more efficient, but the current
> hack is _workable_ (and not any worse than what we historically did)
> even if it's not optimal.
> 
> Right?

Yes.  It allows to drop the current hack, but it's not urgent.

> Oh, and it looks like the first line of the commit message of
> 313d64a35d36 ("do_splice_to(): move the logics for limiting the read
> length in") got truncated somehow..

	Offense against style, actually - preposition torn from object and
moved to the very end of sentence...  "[splice] move the logics for limiting
the read length into do_splice_to()" would probably be better.
pr-tracker-bot@kernel.org Feb. 21, 2021, 6:39 p.m. UTC | #3
The pull request you sent on Sun, 14 Feb 2021 15:19:27 +0000:

> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.sendfile

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/054560e961a0ee4067fccfcfa943335e1aa48928

Thank you!