Message ID | YCk/f0efY5OhibCn@zeniv-ca.linux.org.uk (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [git,pull] sendfile fixes | expand |
On Sun, Feb 14, 2021 at 7:19 AM Al Viro <viro@zeniv.linux.org.uk> wrote: > > Making sendfile() to pipe destination do the right thing, should > make "fs/pipe: allow sendfile() to pipe again" redundant. Sat in -next > for 3 weeks... Just to clarify: this says "fixes", but I get the feeling that you meant for me to pull tomorrow in the 5.12 merge window? I like the patches, but they don't seem to be anything hugely urgent. They should make "sendfile to pipe" more efficient, but the current hack is _workable_ (and not any worse than what we historically did) even if it's not optimal. Right? Oh, and it looks like the first line of the commit message of 313d64a35d36 ("do_splice_to(): move the logics for limiting the read length in") got truncated somehow.. Linus
On Sun, Feb 14, 2021 at 11:35:36AM -0800, Linus Torvalds wrote: > Just to clarify: this says "fixes", but I get the feeling that you > meant for me to pull tomorrow in the 5.12 merge window? > > I like the patches, but they don't seem to be anything hugely urgent. > They should make "sendfile to pipe" more efficient, but the current > hack is _workable_ (and not any worse than what we historically did) > even if it's not optimal. > > Right? Yes. It allows to drop the current hack, but it's not urgent. > Oh, and it looks like the first line of the commit message of > 313d64a35d36 ("do_splice_to(): move the logics for limiting the read > length in") got truncated somehow.. Offense against style, actually - preposition torn from object and moved to the very end of sentence... "[splice] move the logics for limiting the read length into do_splice_to()" would probably be better.
The pull request you sent on Sun, 14 Feb 2021 15:19:27 +0000:
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.sendfile
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/054560e961a0ee4067fccfcfa943335e1aa48928
Thank you!