mbox series

[git,pull] gfs2 setattr patches

Message ID YTmNE6/yK5Q+OIAb@zeniv-ca.linux.org.uk (mailing list archive)
State New, archived
Headers show
Series [git,pull] gfs2 setattr patches | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.gfs2

Message

Al Viro Sept. 9, 2021, 4:26 a.m. UTC
The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3:

  Linux 5.14-rc1 (2021-07-11 15:07:40 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.gfs2

for you to fetch changes up to d75b9fa053e4cd278281386d860c26fdbfbe9d03:

  gfs2: Switch to may_setattr in gfs2_setattr (2021-08-13 00:41:05 -0400)

----------------------------------------------------------------
Andreas Gruenbacher (2):
      fs: Move notify_change permission checks into may_setattr
      gfs2: Switch to may_setattr in gfs2_setattr

 fs/attr.c          | 50 +++++++++++++++++++++++++++++++-------------------
 fs/gfs2/inode.c    |  4 ++--
 include/linux/fs.h |  2 ++
 3 files changed, 35 insertions(+), 21 deletions(-)

Comments

Linus Torvalds Sept. 9, 2021, 7:41 p.m. UTC | #1
On Wed, Sep 8, 2021 at 9:27 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.gfs2
>
> for you to fetch changes up to d75b9fa053e4cd278281386d860c26fdbfbe9d03:
>
>   gfs2: Switch to may_setattr in gfs2_setattr (2021-08-13 00:41:05 -0400)

Explanation for what this series actually does?

I can see the shortlog, I can look at the commits, but I really want a
summary in the pull request.

                Linus
Al Viro Sept. 9, 2021, 7:46 p.m. UTC | #2
On Thu, Sep 09, 2021 at 12:41:33PM -0700, Linus Torvalds wrote:
> On Wed, Sep 8, 2021 at 9:27 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.gfs2
> >
> > for you to fetch changes up to d75b9fa053e4cd278281386d860c26fdbfbe9d03:
> >
> >   gfs2: Switch to may_setattr in gfs2_setattr (2021-08-13 00:41:05 -0400)
> 
> Explanation for what this series actually does?
> 
> I can see the shortlog, I can look at the commits, but I really want a
> summary in the pull request.

Basically, gfs2 has redo the permission checks after it grabs a cluster lock,
and they want to have that doable by call of shared helper, rather than
open-coding those checks.  Looks reasonable to me...
pr-tracker-bot@kernel.org Sept. 9, 2021, 8:04 p.m. UTC | #3
The pull request you sent on Thu, 9 Sep 2021 04:26:59 +0000:

> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.gfs2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7b871c7713d1eafc3a614883bbdf68ab1dffa883

Thank you!