mbox series

[git,pull] build fix

Message ID YqT8fYe1PqP9rCRs@zeniv-ca.linux.org.uk (mailing list archive)
State New, archived
Headers show
Series [git,pull] build fix | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git tags/pull-fixes

Message

Al Viro June 11, 2022, 8:35 p.m. UTC
The following changes since commit 6c77676645ad42993e0a8bdb8dafa517851a352a:

  iov_iter: Fix iter_xarray_get_pages{,_alloc}() (2022-06-10 15:56:32 -0400)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git tags/pull-fixes

for you to fetch changes up to 5632561eee9faa6d8d9f69bf69d083f1847d1abd:

  fix warnings on 32bit caused by ITER_XARRAY fix (2022-06-11 12:43:21 -0400)

----------------------------------------------------------------
minimal fix for build breakage on 32bit
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

----------------------------------------------------------------
There's a bunch of obvious cleanups and improvements in that area; this is
just the braino fix for previous commit.  I wanted to include at least
replacement of weird open-coded count = DIV_ROUND_UP(size + offset, PAGE_SIZE);
in those two functions (it might have started as defense against theoretical
overflows, but if so it's incomplete, the overflows are in practice impossible
*and* this prevention would be in the wrong place anyway), but... let's
keep that separate.

FWIW, in my local tree duplication between iov_iter_get_pages() and
iov_iter_get_pages_alloc() is gone, with a lot of stuff getting considerably
simpler, but I'm still cleaning/reordering/carving that series up.  Will post
tomorrow or on Monday, but those are clearly not 5.19 fodder.

Al Viro (1):
      fix warnings on 32bit caused by ITER_XARRAY fix

 lib/iov_iter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Linus Torvalds June 11, 2022, 8:54 p.m. UTC | #1
On Sat, Jun 11, 2022 at 1:35 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
>   fix warnings on 32bit caused by ITER_XARRAY fix (2022-06-11 12:43:21 -0400)

I already fixed this in my tree (identically to your fix) earlier
today, since I was cc'd on the same report from Sudhip..

Commit 1c27f1fc1549 ("iov_iter: fix build issue due to possible type mis-match")

            Linus