Message ID | a34bqdrz33jw26a5px4ul3eid5zudgaxavc2xqoftk2tywgi5w@ghgoiavnkhtd (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [GIT,PULL] More bcachefs updates for 6.8-rc1 | expand |
On Sun, 21 Jan 2024 at 13:35, Kent Overstreet <kent.overstreet@linux.dev> wrote: > > Hi Linus, another small bcachefs pull. Some fixes, Some refactoring, > some minor features. I'm taking this, but only because bcachefs is new. You need to be aware that the merge window is for *merging*. Not for new development. And almost all of the code here is new development. What you send during the merge window is stuff that should all have been ready *before* the merge window opened, not whatever random changes you made during it. Now, fixes happen any time, but for that argument to work they need to be real fixes. Not "reorganize the code to make things easier to fix" with the fix being something small on top of a big change. Linus
The pull request you sent on Sun, 21 Jan 2024 16:35:06 -0500:
> https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-2024-01-21
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/35a4474b5c3dd4315f72bd53e87b97f128d9bb3d
Thank you!
On Sun, Jan 21, 2024 at 02:05:55PM -0800, Linus Torvalds wrote: > On Sun, 21 Jan 2024 at 13:35, Kent Overstreet <kent.overstreet@linux.dev> wrote: > > > > Hi Linus, another small bcachefs pull. Some fixes, Some refactoring, > > some minor features. > > I'm taking this, but only because bcachefs is new. > > You need to be aware that the merge window is for *merging*. Not for > new development. > > And almost all of the code here is new development. > > What you send during the merge window is stuff that should all have > been ready *before* the merge window opened, not whatever random > changes you made during it. > > Now, fixes happen any time, but for that argument to work they need to > be real fixes. Not "reorganize the code to make things easier to fix" > with the fix being something small on top of a big change. I thought the merge window was still open until tonight?