| Message ID | aa4aa155-b9b2-9099-b7a2-349d8d9d8fbd@paragon-software.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL] ntfs3: new NTFS driver for 5.15 | expand |
On Fri, Sep 3, 2021 at 8:19 AM Konstantin Komarov <almaz.alexandrovich@paragon-software.com> wrote: > > https://github.com/Paragon-Software-Group/linux-ntfs3.git master Oh, I didn't notice this until now, as I was lining up to actually pull this. I probably forgot to say this originally: For github accounts (or really, anything but kernel.org where I can just trust the account management), I really want the pull request to be a signed tag, not just a plain branch. In a perfect world, it would be a PGP signature that I can trace directly to you through the chain of trust, but I've never actually required that. So while I prefer to see a full chain of trust, I realize that isn't always easy to set up, and so at least I want to see an "identity" that stays constant so that I can see that pulls come from the same consistent source that controls that key. (We've also had situations where the chain of trust just didn't exist _yet_, but then later on it can be established as a developer ends up becoming more integral in the community) Signed tags are easy to use - the hardest part is having any pgp key setup at all, then git makes using the keys trivial with "git tag -s .." Linus
On Sat, Sep 4, 2021 at 10:34 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > For github accounts (or really, anything but kernel.org where I can > just trust the account management), I really want the pull request to > be a signed tag, not just a plain branch. Ok, to expedite this all and not cause any further pointless churn and jumping through hoops, I'll let it slide this time, but I'll ask that you sort out your pgp key for the future and use signed tags. Also, I notice that you have a github merge commit in there. That's another of those things that I *really* don't want to see - github creates absolutely useless garbage merges, and you should never ever use the github interfaces to merge anything. This is the complete commit message of that merge: Merge branch 'torvalds:master' into master Yeah, that's not an acceptable message. Not to mention that it has a bogus "github.com" committer etc. github is a perfectly fine hosting site, and it does a number of other things well too, but merges is not one of those things. Linux kernel merges need to be done *properly*. That means proper commit messages with information about what is being merged and *why* you merge something. But it also means proper authorship and committer information etc. All of which github entirely screws up. We had this same issue with the ksmbd pull request, and my response is the same: the initial pull often has a few oddities and I'll accept them now, but for continued development you need to do things properly. That means doing merges from the command line, not using the entirely broken github web interface. (Sadly, it looks like that ksmbd discussion was not on any mailing lists, so I can't link to it). Linus
The pull request you sent on Fri, 3 Sep 2021 18:19:50 +0300:
> https://github.com/Paragon-Software-Group/linux-ntfs3.git master
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f7464060f7ab9a2424428008f0ee9f1e267e410f
Thank you!
Hi Linus, Please pull this branch containing ntfs3 code for 5.15. This is NTFS read-write driver. Current version works with normal/compressed/sparse files and supports acl, NTFS journal replaying. Most of the code was in linux-next branch since Aug 13, but there are some patches, that were in linux-next branch only for a couple of days. Hopefully it is ok - no regression was detected in tests. Linus, sorry for messing up, but there was a back merge from Linux 5.14-rc5 to 5.14-rc7 with github web interface. There is build failure after merge of the overlayfs tree in linux-next [1]. Regards, Konstantin [1]: https://lore.kernel.org/linux-next/20210819093910.55f96720@canb.auug.org.au/ ---------------------------------------------------------------- The following changes since commit 36a21d51725af2ce0700c6ebcb6b9594aac658a6: Linux 5.14-rc5 (Sun Aug 8 13:49:31 2021 -0700) are available in the Git repository at: https://github.com/Paragon-Software-Group/linux-ntfs3.git master for you to fetch changes up to 2e3a51b59ea26544303e168de8a0479915f09aa3: fs/ntfs3: Change how module init/info messages are displayed (Sun Aug 29 17:42:39 2021 +0300) ---------------------------------------------------------------- Konstantin Komarov (12) fs/ntfs3: Restyle comments to better align with kernel-doc fs/ntfs3: Rework file operations fs/ntfs3: Add MAINTAINERS fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile fs/ntfs3: Add Kconfig, Makefile and doc fs/ntfs3: Add NTFS journal fs/ntfs3: Add compression fs/ntfs3: Add attrib operations fs/ntfs3: Add file operations and implementation fs/ntfs3: Add bitmap fs/ntfs3: Add initialization of super block fs/ntfs3: Add headers and misc files Kari Argillander (13) fs/ntfs3: Change how module init/info messages are displayed fs/ntfs3: Remove GPL boilerplates from decompress lib files fs/ntfs3: Remove unnecessary condition checking from ntfs_file_read_iter fs/ntfs3: Fix integer overflow in ni_fiemap with fiemap_prep() fs/ntfs3: Remove fat ioctl's from ntfs3 driver for now fs/ntfs3: Restyle comments to better align with kernel-doc fs/ntfs3: Use kcalloc/kmalloc_array over kzalloc/kmalloc fs/ntfs3: Do not use driver own alloc wrappers fs/ntfs3: Use kernel ALIGN macros over driver specific fs/ntfs3: Restyle comment block in ni_parse_reparse() fs/ntfs3: Fix one none utf8 char in source file fs/ntfs3: Add ifndef + define to all header files fs/ntfs3: Use linux/log2 is_power_of_2 function Dan Carpenter (5) fs/ntfs3: Fix error handling in indx_insert_into_root() fs/ntfs3: Potential NULL dereference in hdr_find_split() fs/ntfs3: Fix error code in indx_add_allocate() fs/ntfs3: fix an error code in ntfs_get_acl_ex() fs/ntfs3: add checks for allocation failure Jiapeng Chong (1) fs/ntfs3: Remove unused including <linux/version.h> Gustavo A. R. Silva (1) fs/ntfs3: Fix fall-through warnings for Clang Nathan Chancellor (1) fs/ntfs3: Remove unused variable cnt in ntfs_security_init() Colin Ian King (2) fs/ntfs3: Fix integer overflow in multiplication fs/ntfs3: Fix various spelling mistakes Documentation/filesystems/index.rst | 1 + Documentation/filesystems/ntfs3.rst | 106 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/Kconfig | 46 +++ fs/ntfs3/Makefile | 36 ++ fs/ntfs3/attrib.c | 2093 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/attrlist.c | 460 +++++++++++++++++++++ fs/ntfs3/bitfunc.c | 134 +++++++ fs/ntfs3/bitmap.c | 1493 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/debug.h | 52 +++ fs/ntfs3/dir.c | 599 ++++++++++++++++++++++++++++ fs/ntfs3/file.c | 1251 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/frecord.c | 3257 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/fslog.c | 5217 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/fsntfs.c | 2509 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/index.c | 2650 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/inode.c | 1957 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/lib/decompress_common.c | 319 +++++++++++++++ fs/ntfs3/lib/decompress_common.h | 338 ++++++++++++++++ fs/ntfs3/lib/lib.h | 26 ++ fs/ntfs3/lib/lzx_decompress.c | 670 +++++++++++++++++++++++++++++++ fs/ntfs3/lib/xpress_decompress.c | 142 +++++++ fs/ntfs3/lznt.c | 453 +++++++++++++++++++++ fs/ntfs3/namei.c | 411 +++++++++++++++++++ fs/ntfs3/ntfs.h | 1216 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/ntfs_fs.h | 1111 +++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/record.c | 605 ++++++++++++++++++++++++++++ fs/ntfs3/run.c | 1113 +++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/super.c | 1512 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ntfs3/upcase.c | 108 +++++ fs/ntfs3/xattr.c | 1119 +++++++++++++++++++++++++++++++++++++++++++++++++++ 30 files changed, 31004 insertions(+)