From patchwork Sun Jun 28 13:22:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikulas Patocka X-Patchwork-Id: 6686141 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D83659F39B for ; Sun, 28 Jun 2015 13:22:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F2DA420562 for ; Sun, 28 Jun 2015 13:22:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D85720525 for ; Sun, 28 Jun 2015 13:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752419AbbF1NWb (ORCPT ); Sun, 28 Jun 2015 09:22:31 -0400 Received: from 78-80-28-91.tmcz.cz ([78.80.28.91]:45477 "EHLO leontynka.twibright.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752145AbbF1NWa (ORCPT ); Sun, 28 Jun 2015 09:22:30 -0400 X-Greylist: delayed 329 seconds by postgrey-1.27 at vger.kernel.org; Sun, 28 Jun 2015 09:22:30 EDT Received: from mikulas (helo=localhost) by leontynka.twibright.com with local-esmtp (Exim 4.72) (envelope-from ) id 1Z9CXU-0007h9-VE; Sun, 28 Jun 2015 15:22:28 +0200 Date: Sun, 28 Jun 2015 15:22:28 +0200 (CEST) From: Mikulas Patocka X-X-Sender: mikulas@leontynka To: Linus Torvalds cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH] hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Joe Perches Date: Thu, 26 Mar 2015 20:47:10 -0700 Removing unnecessary static buffers is good. Use the vsprintf %pV extension instead. Signed-off-by: Joe Perches Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org # v2.6.36+ --- fs/hpfs/super.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-4.1/fs/hpfs/super.c =================================================================== --- linux-4.1.orig/fs/hpfs/super.c 2015-06-22 21:28:15.000000000 +0200 +++ linux-4.1/fs/hpfs/super.c 2015-06-22 21:28:25.000000000 +0200 @@ -53,17 +53,20 @@ static void unmark_dirty(struct super_bl } /* Filesystem error... */ -static char err_buf[1024]; - void hpfs_error(struct super_block *s, const char *fmt, ...) { + struct va_format vaf; va_list args; va_start(args, fmt); - vsnprintf(err_buf, sizeof(err_buf), fmt, args); + + vaf.fmt = fmt; + vaf.va = &args; + + pr_err("filesystem error: %pV", &vaf); + va_end(args); - pr_err("filesystem error: %s", err_buf); if (!hpfs_sb(s)->sb_was_error) { if (hpfs_sb(s)->sb_err == 2) { pr_cont("; crashing the system because you wanted it\n");