diff mbox series

proc,fcntl: fix ifnullfree.cocci warnings

Message ID alpine.DEB.2.21.2007271241000.3288@hadrien (mailing list archive)
State New, archived
Headers show
Series proc,fcntl: fix ifnullfree.cocci warnings | expand

Commit Message

Julia Lawall July 27, 2020, 10:42 a.m. UTC 
From: kernel test robot <lkp@intel.com>

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Pascal Bouchareine <kalou@tfz.net>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/0day-ci/linux/commits/UPDATE-20200726-101057/Pascal-Bouchareine/proc-fcntl-introduce-F_SET_DESCRIPTION/20200726-053047
head:   56b3babdfa5600eeed065807fd6e80d150b1766b
commit: 56b3babdfa5600eeed065807fd6e80d150b1766b [1/1] proc,fcntl: introduce F_SET_DESCRIPTION
:::::: branch date: 27 hours ago
:::::: commit date: 27 hours ago

Please take the patch only if it's a positive warning. Thanks!

 file_table.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series

Patch

--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -272,8 +272,7 @@  static void __fput(struct file *file)
 	eventpoll_release(file);
 	locks_remove_file(file);

-	if (file->f_description)
-		kfree(file->f_description);
+	kfree(file->f_description);

 	ima_file_free(file);
 	if (unlikely(file->f_flags & FASYNC)) {