| Message ID | b5c2d119ccfb0759cf8156c534f2270614f0eba2.1469997250.git.salah.triki@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 31/07/16 21:34, Salah Triki wrote: > off is reinitialized by befs_read_datastream, so no need to init it with > zero in the beginning of befs_bt_read_node. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > fs/befs/btree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > index e59ad20..a0e8cfa 100644 > --- a/fs/befs/btree.c > +++ b/fs/befs/btree.c > @@ -196,7 +196,7 @@ static int > befs_bt_read_node(struct super_block *sb, const befs_data_stream *ds, > struct befs_btree_node *node, befs_off_t node_off) > { > - uint off = 0; > + uint off; > > befs_debug(sb, "---> %s", __func__); > > Hi Salah, I will quote Andrew here: "With this code: int foo; bar(&foo); whatever = foo; some versions of gcc will warn that foo might be used uninitialized. Other versions of gcc don't do this. That's why the seemingly-unneeded initializations are there." You can read the rest of his reply to when I sent the same change 2 months ago :) https://lkml.org/lkml/2016/6/1/875 Sorry, I agree with him to keep the code as it is. Nacked. Thanks, Luis -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/befs/btree.c b/fs/befs/btree.c index e59ad20..a0e8cfa 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@ -196,7 +196,7 @@ static int befs_bt_read_node(struct super_block *sb, const befs_data_stream *ds, struct befs_btree_node *node, befs_off_t node_off) { - uint off = 0; + uint off; befs_debug(sb, "---> %s", __func__);
off is reinitialized by befs_read_datastream, so no need to init it with zero in the beginning of befs_bt_read_node. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- fs/befs/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)