From patchwork Thu May 3 22:08:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ernesto_A=2E_Fern=C3=A1ndez?= X-Patchwork-Id: 10379385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7C5B16037D for ; Thu, 3 May 2018 22:08:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DF5729226 for ; Thu, 3 May 2018 22:08:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 22E5A2922B; Thu, 3 May 2018 22:08:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A4E8D29226 for ; Thu, 3 May 2018 22:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751152AbeECWI3 (ORCPT ); Thu, 3 May 2018 18:08:29 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:46853 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbeECWI2 (ORCPT ); Thu, 3 May 2018 18:08:28 -0400 Received: by mail-qt0-f194.google.com with SMTP id m16-v6so24977779qtg.13 for ; Thu, 03 May 2018 15:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding; bh=Nvq2ELo9zJBLBLZrr38qkWf5P43NT9bYl1lNIxtyGHA=; b=nokqUYXHEtn3aHij9C+jDfchYATxyGu4DgftMDjEXehaKigLSYcHNyYF2SvhLoes+U mJ74tguLKZWqpj+3bgj2i4f4kdJzHJKBJbhNfA/0Y79GXvvq4UCzP9ExpJPOg0lbs+GK AQnpagcC9DowovDTFl3nrjG7H/XksgvoyMjUMkm+VHk8XulFNZVfGfexVwDvlhxBjvUx 73zPQMvaRYmFS4/E7nlrQp30gRWzEoFDI8DmZhDYVUt8voMmPeOWvk1F0gX3VQP3GY0d 98ARvluYlJ6g9/u5DtjMhZN4ybfyS4ILWsBjnImQQ4OlaTGdaCTWkxrRxzfldAgblUXg b3ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding; bh=Nvq2ELo9zJBLBLZrr38qkWf5P43NT9bYl1lNIxtyGHA=; b=QxToh3rPLthuim8Cxcx+67TnSgMyY3YV6MUfeHgy/a+m/vh1eGjcoX+XFipBeROcje 0HKUlIpBK+lyEitiJ8+l1arUba1MmPPLu10qngp+k3cXJ9gsQy7nc6DMAyn2jzMbqFA4 Md2xMl/QdHw5ZKema05posaQgRCOfZhIIJnebBSls2x+eu321pPBiKbGdXBwafHtWFLi gpqUq42odS/g/peQZJ47PQpKVgrHXCfb5mqqIxy9iJ5qHQWilGhAjidj0BcwR7VqcU67 sJA8zMjIuOu+NofepRJwOxutlwZgDo68T5RaBOieu9cEsv8oxVvbBCi3v5FZOhFQjAH4 yYVA== X-Gm-Message-State: ALQs6tBpic7FOcrbD2GKqAQLYUSaOfXzmjy1thSvRPpW9XhqESOkE6jm MQSGR2w5CBZSehnSAvMm5nM= X-Google-Smtp-Source: AB8JxZq1srGbWcufQ8efyu37nj8Pp9K93+JzdBPQZWZ3vVjXRI2gz36YdOk+cJ3Oz+umvw7U90Tb2A== X-Received: by 2002:a0c:9655:: with SMTP id 21-v6mr21262531qvy.226.1525385307500; Thu, 03 May 2018 15:08:27 -0700 (PDT) Received: from eaf ([181.47.179.0]) by smtp.gmail.com with ESMTPSA id 47-v6sm9184428qtw.4.2018.05.03.15.08.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 15:08:27 -0700 (PDT) Date: Thu, 3 May 2018 19:08:22 -0300 From: Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?= To: syzbot Cc: Andrew Morton , Christoph Hellwig , Alexey Khoroshilov , Artem Bityutskiy , Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?= , linux-fsdevel@vger.kernel.org Subject: [PATCH 1/2] hfsplus: clean up delayed work if fill_super fails Message-ID: MIME-Version: 1.0 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If no hidden directory exists, the hfsplus_fill_super() function will create it. A delayed work is then queued to sync the superblock, which is never canceled in case of failure. Fix this. Fixes: 9e6c5829b07c ("hfsplus: get rid of write_super") Reported-by: syzbot+4f2e5f086147d543ab03@syzkaller.appspotmail.com Signed-off-by: Ernesto A. Fernández --- fs/hfsplus/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index 513c357c734b..4bc49e3f171d 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c @@ -588,6 +588,8 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent) return 0; out_put_hidden_dir: + /* Creating an inode queues the sb for synchronization */ + cancel_delayed_work_sync(&sbi->sync_work); iput(sbi->hidden_dir); out_put_root: dput(sb->s_root);