mbox series

[GIT,PULL] ntfs3: bugfixes for 6.0

Message ID db8cb5d9-56d6-a00a-9cf0-4deec9056433@paragon-software.com (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] ntfs3: bugfixes for 6.0 | expand


https://github.com/Paragon-Software-Group/linux-ntfs3.git ntfs3_for_6.0


Konstantin Komarov Aug. 17, 2022, 4:43 p.m. UTC
Hi Linus,

Please pull this branch containing ntfs3 code for 6.0.

- some logic errors;
- fixed xfstests (tested on x86_64)
generic/064 generic/213 generic/300 generic/361 generic/449 generic/485;
- some dead code was removed or refactored.

Most of the code was in linux-next branch for several weeks,
but there are some patches, that were in linux-next branch only
for a week.




The following changes since commit 724bbe49c5e427cb077357d72d240a649f2e4054:

   fs/ntfs3: provide block_invalidate_folio to fix memory leak (Mon May 30 13:36:45 2022 +0200)

are available in the Git repository at:

   https://github.com/Paragon-Software-Group/linux-ntfs3.git ntfs3_for_6.0

for you to fetch changes up to d4073595d0c61463ec3a87411b19e2a90f76d3f8:

   fs/ntfs3: uninitialized variable in ntfs_set_acl_ex() (Mon Aug 8 11:34:41 2022 +0300)


Christophe JAILLET (1)
  fs/ntfs3: Remove a useless test

Colin Ian King (3)
  fs/ntfs3: Remove duplicated assignment to variable r
  fs/ntfs3: Remove redundant assignment to variable vcn
  fs/ntfs3: Remove redundant assignment to variable frame

Yan Lei (1)
  fs/ntfs3: Fix using uninitialized value n when calling indx_read

Yang Xu (1)
  fs/ntfs3: Use the same order for acl pointer check in ntfs_init_acl

Dan Carpenter (3)
  fs/ntfs3: uninitialized variable in ntfs_set_acl_ex()
  fs/ntfs3: Unlock on error in attr_insert_range()
  fs/ntfs3: Don't clear upper bits accidentally in log_replay()

Pavel Skripkin (2)
  fs/ntfs3: Make ntfs_update_mftmirr return void
  fs/ntfs3: Fix NULL deref in ntfs_update_mftmirr

Li Kunyu (1)
  fs/ntfs3: Remove unnecessary 'NULL' values from pointers

Jiapeng Chong (1)
  fs/ntfs3: Remove unused function wnd_bits

Konstantin Komarov (26)
  fs/ntfs3: Make ni_ins_new_attr return error
  fs/ntfs3: Create MFT zone only if length is large enough
  fs/ntfs3: Refactoring attr_insert_range to restore after errors
  fs/ntfs3: Refactoring attr_punch_hole to restore after errors
  fs/ntfs3: Refactoring attr_set_size to restore after errors
  fs/ntfs3: New function ntfs_bad_inode
  fs/ntfs3: Make MFT zone less fragmented
  fs/ntfs3: Check possible errors in run_pack in advance
  fs/ntfs3: Added comments to frecord functions
  fs/ntfs3: Fill duplicate info in ni_add_name
  fs/ntfs3: Make static function attr_load_runs
  fs/ntfs3: Add new argument is_mft to ntfs_mark_rec_free
  fs/ntfs3: Remove unused mi_mark_free
  fs/ntfs3: Fix very fragmented case in attr_punch_hole
  fs/ntfs3: Fix work with fragmented xattr
  fs/ntfs3: Make ntfs_fallocate return -ENOSPC instead of -EFBIG
  fs/ntfs3: extend ni_insert_nonresident to return inserted ATTR_LIST_ENTRY
  fs/ntfs3: Check reserved size for maximum allowed
  fs/ntfs3: Do not change mode if ntfs_set_ea failed
  fs/ntfs3: Enable FALLOC_FL_INSERT_RANGE
  fs/ntfs3: Fallocate (FALLOC_FL_INSERT_RANGE) implementation
  fs/ntfs3: Add missing error check
  fs/ntfs3: Fix missing i_op in ntfs_read_mft
  fs/ntfs3: Refactor ni_try_remove_attr_list function
  fs/ntfs3: Fix double free on remount
  fs/ntfs3: Refactoring of indx_find function

  fs/ntfs3/attrib.c  | 557 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------
  fs/ntfs3/bitmap.c  |  12 +---
  fs/ntfs3/file.c    | 110 +++++++++++++++++------------
  fs/ntfs3/frecord.c | 128 +++++++++++++++++++++++----------
  fs/ntfs3/fslog.c   |   4 +-
  fs/ntfs3/fsntfs.c  |  92 +++++++++++++++---------
  fs/ntfs3/index.c   |  33 ++++-----
  fs/ntfs3/inode.c   |  19 ++---
  fs/ntfs3/namei.c   |   6 +-
  fs/ntfs3/ntfs_fs.h |  16 +++--
  fs/ntfs3/record.c  |  27 +------
  fs/ntfs3/run.c     | 108 +++++++++++++++++++++++-----
  fs/ntfs3/super.c   |  17 +++--
  fs/ntfs3/xattr.c   |  35 +++++----
  14 files changed, 835 insertions(+), 329 deletions(-)


Linus Torvalds Aug. 17, 2022, 9:55 p.m. UTC | #1
On Wed, Aug 17, 2022 at 9:43 AM Konstantin Komarov
<almaz.alexandrovich@paragon-software.com> wrote:
> Please pull this branch containing ntfs3 code for 6.0.

This really should have come in during the merge window.

Yes, there are clearly several fixes in here, but at least that
FALLOC_FL_INSERT_RANGE is clearly new development. And a lot of it
looks like just refactoring and cleanup, and again that is something
that should come in during the merge window.

But since this all affects only ntfs3, and I consider that still
fairly solidly experimental, I'll let it slide. But please keep this
in mind for next time - new work (whether cleanups or actual new code)
during the merge window, and obvious fixes afterwards.

pr-tracker-bot@kernel.org Aug. 17, 2022, 10:20 p.m. UTC | #2
The pull request you sent on Wed, 17 Aug 2022 19:43:51 +0300:

> https://github.com/Paragon-Software-Group/linux-ntfs3.git ntfs3_for_6.0

has been merged into torvalds/linux.git:

Thank you!