From patchwork Wed Jul 27 03:11:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salah Triki X-Patchwork-Id: 9249209 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 61E56607D8 for ; Wed, 27 Jul 2016 03:12:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55917276AE for ; Wed, 27 Jul 2016 03:12:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 497E027BFA; Wed, 27 Jul 2016 03:12:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD17E276AE for ; Wed, 27 Jul 2016 03:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756903AbcG0DMj (ORCPT ); Tue, 26 Jul 2016 23:12:39 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33932 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbcG0DMW (ORCPT ); Tue, 26 Jul 2016 23:12:22 -0400 Received: by mail-wm0-f66.google.com with SMTP id q128so4434497wma.1; Tue, 26 Jul 2016 20:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=PD966jbt7pw5G420KFqxWU3BdIksxE1qosWTEYWQLWg=; b=lPCbmIwX9vWqYrsm5DvwJF5m7eNdCPR48XGFBHoIApvTBt+3GdtASdjJfbRg7eP62x qxc7OF36ChgpYmmxrEB7sM4ZpmlkEmG9PC5QiVbyvLk+viu1mZMZEmdS58xkRLyAYoPB JJ/pDQ4s/PLK82s8vQkfEF0x37v+0CfO5E8CObAPdD+RMA4VbgXCjgEi4JWbS3Q4XWtW mPXijvfc3LVOu5m8TPFM7WnLVQmP5Gaq9tHLEek0ozxqzkohlSi/0oqfkWc7zOti8JYU ehQZFY2BUCjSy9QrKQrIVidxcTIce/7BpLjryMkaA0E32ujIu8zGOGrcbIhuXp7Y2Fy+ xEYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=PD966jbt7pw5G420KFqxWU3BdIksxE1qosWTEYWQLWg=; b=RfyvE3X2aYD7YHRZQIZugSd//TrHmdsoGswAX2XwE9RB7AGMl87jJBPq9ucTVGGoaM zhs0UJGUrKQO28PCd6uDFZu/XBBUyxW3lGQYOrkNz0CW1TTkn96NmD04KbyYhKsxcTlt A/mwl8y8USPwWYpH43Q01VtJXb65hIYDRiLqB288jOedgHSwO+sCcREDzYmFsBpKP1Bc v96o/5kBK3IQTsG9YwB4UcfNu2iMX3R6aID5Og+Ct5+TIs5/JWuvH9eqWzA42KR7s37t yeZ2WxOkodhMvlVdI3j4p1OzSfVS1fn8BsxQBKLLeynp8scMGXv02uWcesUy9QYjJ1cu ckwA== X-Gm-Message-State: AEkoouvBZ/DBM4Cdkhc+ynv8plaYE+ZMKi+Np9TPW0g5iBO07r7BpgLu+y9yuLWdAI9eUA== X-Received: by 10.28.165.207 with SMTP id o198mr30107035wme.87.1469589140890; Tue, 26 Jul 2016 20:12:20 -0700 (PDT) Received: from localhost.localdomain ([41.224.169.131]) by smtp.gmail.com with ESMTPSA id e65sm4696967wmg.3.2016.07.26.20.12.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jul 2016 20:12:20 -0700 (PDT) From: Salah Triki To: akpm@linux-foundation.org, viro@ZenIV.linux.org.uk Cc: luisbg@osg.samsung.com, mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, salah.triki@gmail.com Subject: [RESEND PATCH 3/4] fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect Date: Wed, 27 Jul 2016 04:11:54 +0100 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: <9859a616787673d2f36ce21d4aa0220637c55001.1469588473.git.salah.triki@gmail.com> References: <9859a616787673d2f36ce21d4aa0220637c55001.1469588473.git.salah.triki@gmail.com> In-Reply-To: <9859a616787673d2f36ce21d4aa0220637c55001.1469588473.git.salah.triki@gmail.com> References: <9859a616787673d2f36ce21d4aa0220637c55001.1469588473.git.salah.triki@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The calls to brelse are useless since dbl_indir_block and indir_block are NULL. Signed-off-by: Salah Triki Acked-by: Luis de Bethencourt --- fs/befs/datastream.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index e224b9a..b68b6f9 100644 --- a/fs/befs/datastream.c +++ b/fs/befs/datastream.c @@ -471,7 +471,6 @@ befs_find_brun_dblindirect(struct super_block *sb, (unsigned long) iaddr2blockno(sb, &data->double_indirect) + dbl_which_block); - brelse(dbl_indir_block); return BEFS_ERR; } @@ -496,7 +495,6 @@ befs_find_brun_dblindirect(struct super_block *sb, befs_error(sb, "%s couldn't read the indirect block " "at blockno %lu", __func__, (unsigned long) iaddr2blockno(sb, &indir_run) + which_block); - brelse(indir_block); return BEFS_ERR; }