Message ID | ddd61469-637c-4a1f-a024-141574fd76a8@stanley.mountain (mailing list archive) |
---|---|
State | New |
Headers | show
Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14A521170B for <linux-fsdevel@vger.kernel.org>; Wed, 12 Feb 2025 15:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739374074; cv=none; b=LMCYrMXp6XkyJcOzmPephHFkPeCrrvYY4IS6InLzdbHY5XLql0ViN8/+gO8a/6ZiZb/VkP5cItFDv5Dy4RtdQvd6YfiX6aTn+KPWfd3XwPWTJnzxrHXN0ZMY6IlrFcP6Gnz7DfIFOSdfS4VwX3AJOKYLkprHXizbD6MzdE/UXTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739374074; c=relaxed/simple; bh=nGOHHKMn8GtXJDicwnkL8tmz9VcKp2LxDT7FzaficDQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=GO/gI5SdOXLdQt09kwMHwa06n1F0QlqjG1gecxaLLn+wzcWC4jbmkfPlwRhIqjJWTEtC2wR6DV/LnxLJLSOwOTCGmG1pp8Bh6Gqf+eQzXFSAdhrS5owuEAV9amx5fm72v8dyNTzvmztDga4NVvjm5RYm67Rnd8bwn0Mq0stx5oM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=laZvZrLv; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="laZvZrLv" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ab7c6fc35b3so576192366b.2 for <linux-fsdevel@vger.kernel.org>; Wed, 12 Feb 2025 07:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739374070; x=1739978870; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=gIK/hsLjBmZb4Q7phf+8q1FhCeVWqfbKwX81hLs6leU=; b=laZvZrLvajbe2NVmhCSHQkDLWb84Kp2eSfV0E9fjiZ0hDzBWt7T15XZM3Anp8FpC/8 75KKTUx5rQ3P2ObiIGcxyImsSbpRd4t3LlCiZQ6QAMMppDnnupbyWUWqPIlM4gAvNxOo diABh2kPy4TFr9xlDiW+2LzDex9uU5LlDOCqpJMgQTrdLcaQfPm6UVkfXgessfNkr6no mUtquWoWyCCjxbWCxWy09TOjRzvRDughZg6V7GVyC7oHFTutcWYAIpd+bxu63mXmIxO3 Axi6Cplv2dqrfgjLH9WWGIuSNTi4ujywvZhQSOoZ/rAtOUVMToDtZqP9Hs302RaWrNXw ZvsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739374070; x=1739978870; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gIK/hsLjBmZb4Q7phf+8q1FhCeVWqfbKwX81hLs6leU=; b=UAA8Hsv2zzrFADWe6VLr2fs/QrQCO0viDceMzL/wsrzxMA9eUs65RhN6PmXWeqdkbz 3lv6XbpiTX+U5NkHdwvhFpzRdWjJRiwoyhq65iA3iq0bNfU7+KnsR4gAJwN2faTiyLj2 C6gBhcvB9L+h2Lp2Ph1HoAnQpJFvUOz1B/57D8P3kIOVJPrSWFyl8JhhzV+ulBs+pZmv CP2ZiZAMssVqRS6kcqmX8ZCDMUmERKwrHSTFKuw/uZ8Of5PNVBjca8gKKQrTS4EDniMO CNEQa9/xNUOxJLqXZ+1tlrauA/X6OR0WC+hubnHksjNeknvtFUHQvNXvfqUaBA7PP17S v32w== X-Forwarded-Encrypted: i=1; AJvYcCU27320vVsHJupgHZi58NAskJPFFnKKdyq2Lo0bIbGtv+ubjk6QJZBHVkk5BAYUY8FKADnmmWm3kmYWkE+m@vger.kernel.org X-Gm-Message-State: AOJu0YyGVE9D5ln24wAA11ttpgLyWto7zKtKKsq5kvsRG1J3cP1ab5wg VU0on2befh0smm400K0Cu9E3O6sLQhYY5VpWziIXeAgSJI1WyU0/bF7EBJXoYr0= X-Gm-Gg: ASbGncuAUVcOYWZEEreG1Goh9yn8ytPWLOcpztZknpYXVtISWyiOUH9gZ3i5HS5HhVZ DbXzUT7snvvefx/x+lqe1PmLT4vbzflrLKOiKow6Hi7BosGRzLmrzO6fr4IWLpYXaqJW7+3DsrN RUPsgtenaxsjApF0JWDRC371mwj6FYqs4v1Uzn9Z7UWxXlV1XdMO8MjrRQubeC/sdNcfUuynSFn VnLkYA2JQkMDIgcceMkZZGBpVqCy61SOON2/4TNYOhHC8GC5Bu4nJlcr4J5pr56ILh0kPc+aRwS kcLfItqUF82nEfuMtzjW X-Google-Smtp-Source: AGHT+IFpL8Nw1g0cPCijD/OhpU2DBTaHM0/BqrJs7pa0K+2D+M9iqhuvdq5hwJqMDWlN3ZppYMHMIA== X-Received: by 2002:a17:906:dc91:b0:ab7:eeae:b23b with SMTP id a640c23a62f3a-ab7f354ed67mr381322466b.0.1739374070037; Wed, 12 Feb 2025 07:27:50 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ab79d9ced43sm967079866b.78.2025.02.12.07.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 07:27:49 -0800 (PST) Date: Wed, 12 Feb 2025 18:27:46 +0300 From: Dan Carpenter <dan.carpenter@linaro.org> To: Dan Williams <dan.j.williams@intel.com> Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>, Matthew Wilcox <willy@infradead.org>, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] fs/dax: Remove unnecessary check in dax_break_layout_final() Message-ID: <ddd61469-637c-4a1f-a024-141574fd76a8@stanley.mountain> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: <linux-fsdevel.vger.kernel.org> List-Subscribe: <mailto:linux-fsdevel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-fsdevel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding |
Series |
fs/dax: Remove unnecessary check in dax_break_layout_final()
|
expand
|
diff --git a/fs/dax.c b/fs/dax.c index 9e4940a0b286..21a743996f90 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -987,8 +987,7 @@ void dax_break_layout_final(struct inode *inode) wait_page_idle_uninterruptible(page, inode); } while (true); - if (!page) - dax_delete_mapping_range(inode->i_mapping, 0, LLONG_MAX); + dax_delete_mapping_range(inode->i_mapping, 0, LLONG_MAX); } EXPORT_SYMBOL_GPL(dax_break_layout_final);
The "page" pointer is always NULL at this point. Adding a check is a bit confusing. Delete it. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- fs/dax.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)