| Message ID | e6b1201c3b5fa88085919908f01ea7337d9c9359.1592203542.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Mon 15-06-20 08:46:46, Mauro Carvalho Chehab wrote: > Changeset 3b0311e7ca71 ("vfs: track per-sb writeback errors and report them to syncfs") > added a variant of filemap_sample_wb_err(), but it forgot to > rename the arguments at the kernel-doc markup. Fix it. > > Fix those warnings: > ./include/linux/fs.h:2845: warning: Function parameter or member 'file' not described in 'file_sample_sb_err' > ./include/linux/fs.h:2845: warning: Excess function parameter 'mapping' description in 'file_sample_sb_err' > > Fixes: 3b0311e7ca71 ("vfs: track per-sb writeback errors and report them to syncfs") > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Thanks for the fix! It looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > include/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 6c4ab4dc1cd7..7e17ecc461d5 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2829,7 +2829,7 @@ static inline errseq_t filemap_sample_wb_err(struct address_space *mapping) > > /** > * file_sample_sb_err - sample the current errseq_t to test for later errors > - * @mapping: mapping to be sampled > + * @file: file pointer to be sampled > * > * Grab the most current superblock-level errseq_t value for the given > * struct file. > -- > 2.26.2 >
diff --git a/include/linux/fs.h b/include/linux/fs.h index 6c4ab4dc1cd7..7e17ecc461d5 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2829,7 +2829,7 @@ static inline errseq_t filemap_sample_wb_err(struct address_space *mapping) /** * file_sample_sb_err - sample the current errseq_t to test for later errors - * @mapping: mapping to be sampled + * @file: file pointer to be sampled * * Grab the most current superblock-level errseq_t value for the given * struct file.
Changeset 3b0311e7ca71 ("vfs: track per-sb writeback errors and report them to syncfs") added a variant of filemap_sample_wb_err(), but it forgot to rename the arguments at the kernel-doc markup. Fix it. Fix those warnings: ./include/linux/fs.h:2845: warning: Function parameter or member 'file' not described in 'file_sample_sb_err' ./include/linux/fs.h:2845: warning: Excess function parameter 'mapping' description in 'file_sample_sb_err' Fixes: 3b0311e7ca71 ("vfs: track per-sb writeback errors and report them to syncfs") Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- include/linux/fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)