| Message ID | f1cfa63dd372df107ef954e90ca2e58b2ecf0a67.1605007036.git.naohiro.aota@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: zoned block device support | expand |
On 10/11/20 7:26 pm, Naohiro Aota wrote: > Add a check in verify_one_dev_extent() to check if a device extent on a > zoned block device is aligned to the respective zone boundary. > > Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com> > Reviewed-by: Josef Bacik <josef@toxicpanda.com> > --- > fs/btrfs/volumes.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c > index 7831cf6c6da4..c0e27c1e2559 100644 > --- a/fs/btrfs/volumes.c > +++ b/fs/btrfs/volumes.c > @@ -7783,6 +7783,20 @@ static int verify_one_dev_extent(struct btrfs_fs_info *fs_info, > ret = -EUCLEAN; > goto out; > } > + > + if (dev->zone_info) { > + u64 zone_size = dev->zone_info->zone_size; > + > + if (!IS_ALIGNED(physical_offset, zone_size) || > + !IS_ALIGNED(physical_len, zone_size)) { > + btrfs_err(fs_info, > +"zoned: dev extent devid %llu physical offset %llu len %llu is not aligned to device zone", > + devid, physical_offset, physical_len); > + ret = -EUCLEAN; > + goto out; > + } > + } > + > out: > free_extent_map(em); > return ret; > Looks good. Reviewed-by: Anand Jain <anand.jain@oracle.com>
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 7831cf6c6da4..c0e27c1e2559 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -7783,6 +7783,20 @@ static int verify_one_dev_extent(struct btrfs_fs_info *fs_info, ret = -EUCLEAN; goto out; } + + if (dev->zone_info) { + u64 zone_size = dev->zone_info->zone_size; + + if (!IS_ALIGNED(physical_offset, zone_size) || + !IS_ALIGNED(physical_len, zone_size)) { + btrfs_err(fs_info, +"zoned: dev extent devid %llu physical offset %llu len %llu is not aligned to device zone", + devid, physical_offset, physical_len); + ret = -EUCLEAN; + goto out; + } + } + out: free_extent_map(em); return ret;