From patchwork Mon Jun 26 23:09:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?0L3QsNCx?= X-Patchwork-Id: 13293595 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A89EB64DC for ; Mon, 26 Jun 2023 23:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230111AbjFZXJb (ORCPT ); Mon, 26 Jun 2023 19:09:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbjFZXJ2 (ORCPT ); Mon, 26 Jun 2023 19:09:28 -0400 Received: from tarta.nabijaczleweli.xyz (unknown [139.28.40.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2D5BE173A; Mon, 26 Jun 2023 16:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nabijaczleweli.xyz; s=202305; t=1687820960; bh=ahR55X1tMPjwCkeOkwkz+mlJGXSwvA70sfFtKUTZ6Ss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aKRjZtezVd/LhdXkFG54SEwZN9ryQa8wFlxFxLBNvRD7v+XexIoRNNaWsxwWiD7KK SfwbA9gGZk/Wbd6xAEEM7d4ympWN90GKQOKfqcc7gQx1v1O0rD8m3ShhrlCO6w0GKt Lf331rDdyp1lrpT4cwdlSw/Ubf4bRQ2aUIUUtWNKetPOwUsVukkO5CzuuXxQy+BhlU qxDF3gIzlTk67ee5x01nR6CsDA9jHF0y2Jzd5fa7KIHTo4SVvZOP+Mx06mY+C5Z95p lH/WmXllzukRrcycICxqvzp4yqNy4iNX1UthdMYk4NEL5yL792W8QKb4uaHHsicrZl 3AS76GIikN2Pw== Received: from tarta.nabijaczleweli.xyz (unknown [192.168.1.250]) by tarta.nabijaczleweli.xyz (Postfix) with ESMTPSA id 591DF179A; Tue, 27 Jun 2023 01:09:20 +0200 (CEST) Date: Tue, 27 Jun 2023 01:09:19 +0200 From: Ahelenia =?utf-8?q?Ziemia=C5=84ska?= To: Amir Goldstein Cc: Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Chung-Chiang Cheng Subject: [PATCH v2 3/3] splice: fsnotify_access(in), fsnotify_modify(out) on success in tee Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20230517 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Same logic applies here: this can fill up the pipe, and pollers that rely on getting IN_MODIFY notifications never wake up. Fixes: 983652c69199 ("splice: report related fsnotify events") Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u Signed-off-by: Ahelenia Ziemiańska Reviewed-by: Amir Goldstein --- fs/splice.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/splice.c b/fs/splice.c index a18274209dc1..3234aaa6e957 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -1819,6 +1819,11 @@ long do_tee(struct file *in, struct file *out, size_t len, unsigned int flags) } } + if (ret > 0) { + fsnotify_access(in); + fsnotify_modify(out); + } + return ret; }