mbox series

[GIT,PULL] bcachefs fixes for 6.14-rc2

Message ID z2eszznjel6knkkvckjxvkp5feo5jhnwvls3rtk7mbt47znvcr@kvo6dhimlghe (mailing list archive)
State New
Headers show
Series [GIT,PULL] bcachefs fixes for 6.14-rc2 | expand

Pull-request

git://evilpiepirate.org/bcachefs.git tags/bcachefs-2025-02-06

Message

Kent Overstreet Feb. 7, 2025, 2:20 a.m. UTC
Nothing major, things continue to be fairly quiet over here.

Tracking some bugs that show up on nix build servers; would like someone
to confirm or deny that these are or are not still happening on 6.14,
and if you've got an environment where this is reproducing and can work
with me to debug that would save me some trouble...

Also, another bug report is implicating hibernate, please let me know if
you have any data on that, still trying to piece together what's going
on there.

And as usual, be noisy if you're seeing a serious bug that's not getting
resolved.

The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b:

  Linux 6.14-rc1 (2025-02-02 15:39:26 -0800)

are available in the Git repository at:

  git://evilpiepirate.org/bcachefs.git tags/bcachefs-2025-02-06

for you to fetch changes up to 44a7bfed6f352b4bae4fd244d0fcd32aa25d0deb:

  bcachefs: bch2_bkey_sectors_need_rebalance() now only depends on bch_extent_rebalance (2025-02-05 19:56:24 -0500)

----------------------------------------------------------------
bcachefs fixes for 6.14-rc2

- add a SubmittingPatches to clarify that patches submitted for bcachefs
  do, in fact, need to be tested
- discard path now correctly issues journal flushes when needed, this
  fixes performance issues when the filesystem is nearly full and we're
  bottlenecked on copygc
- fix a bug that could cause the pending rebalance work accounting to be
  off when devices are being onlined/offlined; users should report if
  they are still seeing this
- and a few more trivial ones

----------------------------------------------------------------
Jeongjun Park (2):
      bcachefs: fix incorrect pointer check in __bch2_subvolume_delete()
      bcachefs: fix deadlock in journal_entry_open()

Kent Overstreet (4):
      bcachefs docs: SubmittingPatches.rst
      bcachefs: Fix discard path journal flushing
      bcachefs: Fix rcu imbalance in bch2_fs_btree_key_cache_exit()
      bcachefs: bch2_bkey_sectors_need_rebalance() now only depends on bch_extent_rebalance

 .../filesystems/bcachefs/SubmittingPatches.rst     | 98 ++++++++++++++++++++++
 MAINTAINERS                                        |  1 +
 fs/bcachefs/alloc_background.c                     | 47 ++++++-----
 fs/bcachefs/alloc_foreground.c                     | 10 ++-
 fs/bcachefs/alloc_types.h                          |  1 +
 fs/bcachefs/btree_key_cache.c                      |  1 -
 fs/bcachefs/buckets_waiting_for_journal.c          | 12 ++-
 fs/bcachefs/buckets_waiting_for_journal.h          |  4 +-
 fs/bcachefs/inode.h                                |  4 +-
 fs/bcachefs/journal.c                              | 18 +++-
 fs/bcachefs/journal.h                              |  1 +
 fs/bcachefs/journal_types.h                        |  1 +
 fs/bcachefs/opts.h                                 | 14 ----
 fs/bcachefs/rebalance.c                            |  8 +-
 fs/bcachefs/rebalance.h                            | 20 +++++
 fs/bcachefs/subvolume.c                            |  7 +-
 fs/bcachefs/super.c                                | 11 +++
 fs/bcachefs/super.h                                |  1 +
 fs/bcachefs/trace.h                                | 14 +++-
 19 files changed, 214 insertions(+), 59 deletions(-)
 create mode 100644 Documentation/filesystems/bcachefs/SubmittingPatches.rst

Comments

Akira Yokosawa Feb. 7, 2025, 3:05 a.m. UTC | #1
Hello Kent,

Kent Overstreet wrote:
> Nothing major, things continue to be fairly quiet over here.
> 
> Tracking some bugs that show up on nix build servers; would like someone
> to confirm or deny that these are or are not still happening on 6.14,
> and if you've got an environment where this is reproducing and can work
> with me to debug that would save me some trouble...
> 
> Also, another bug report is implicating hibernate, please let me know if
> you have any data on that, still trying to piece together what's going
> on there.
> 
> And as usual, be noisy if you're seeing a serious bug that's not getting
> resolved.
> 

I'm not Linus, and not a serious bug, but let me be noisy.

See below.

> The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b:
> 
>   Linux 6.14-rc1 (2025-02-02 15:39:26 -0800)
> 
> are available in the Git repository at:
> 
>   git://evilpiepirate.org/bcachefs.git tags/bcachefs-2025-02-06
> 
> for you to fetch changes up to 44a7bfed6f352b4bae4fd244d0fcd32aa25d0deb:
> 
>   bcachefs: bch2_bkey_sectors_need_rebalance() now only depends on bch_extent_rebalance (2025-02-05 19:56:24 -0500)
> 
> ----------------------------------------------------------------
> bcachefs fixes for 6.14-rc2
> 
> - add a SubmittingPatches to clarify that patches submitted for bcachefs
>   do, in fact, need to be tested
> - discard path now correctly issues journal flushes when needed, this
>   fixes performance issues when the filesystem is nearly full and we're
>   bottlenecked on copygc
> - fix a bug that could cause the pending rebalance work accounting to be
>   off when devices are being onlined/offlined; users should report if
>   they are still seeing this
> - and a few more trivial ones
> 
> ----------------------------------------------------------------
> Jeongjun Park (2):
>       bcachefs: fix incorrect pointer check in __bch2_subvolume_delete()
>       bcachefs: fix deadlock in journal_entry_open()
> 
> Kent Overstreet (4):
>       bcachefs docs: SubmittingPatches.rst

This caused a new warning in "make htmldocs", which was reported at:

    https://lore.kernel.org/20250204141216.4a2635ee@canb.auug.org.au/

, and has not been taken care of.

I'd like you not to ignore such a friendly report!

Regards, Akira

>       bcachefs: Fix discard path journal flushing
>       bcachefs: Fix rcu imbalance in bch2_fs_btree_key_cache_exit()
>       bcachefs: bch2_bkey_sectors_need_rebalance() now only depends on bch_extent_rebalance
> 
>  .../filesystems/bcachefs/SubmittingPatches.rst     | 98 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  fs/bcachefs/alloc_background.c                     | 47 ++++++-----
>  fs/bcachefs/alloc_foreground.c                     | 10 ++-
>  fs/bcachefs/alloc_types.h                          |  1 +
>  fs/bcachefs/btree_key_cache.c                      |  1 -
>  fs/bcachefs/buckets_waiting_for_journal.c          | 12 ++-
>  fs/bcachefs/buckets_waiting_for_journal.h          |  4 +-
>  fs/bcachefs/inode.h                                |  4 +-
>  fs/bcachefs/journal.c                              | 18 +++-
>  fs/bcachefs/journal.h                              |  1 +
>  fs/bcachefs/journal_types.h                        |  1 +
>  fs/bcachefs/opts.h                                 | 14 ----
>  fs/bcachefs/rebalance.c                            |  8 +-
>  fs/bcachefs/rebalance.h                            | 20 +++++
>  fs/bcachefs/subvolume.c                            |  7 +-
>  fs/bcachefs/super.c                                | 11 +++
>  fs/bcachefs/super.h                                |  1 +
>  fs/bcachefs/trace.h                                | 14 +++-
>  19 files changed, 214 insertions(+), 59 deletions(-)
>  create mode 100644 Documentation/filesystems/bcachefs/SubmittingPatches.rst
Kent Overstreet Feb. 7, 2025, 3:41 a.m. UTC | #2
On Fri, Feb 07, 2025 at 12:05:05PM +0900, Akira Yokosawa wrote:
> This caused a new warning in "make htmldocs", which was reported at:

Yep, I missed that, here's an updated pull:

The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b:

  Linux 6.14-rc1 (2025-02-02 15:39:26 -0800)

are available in the Git repository at:

  git://evilpiepirate.org/bcachefs.git tags/bcachefs-2025-02-06.2

for you to fetch changes up to 4be214c26936813b636eed2fac906f585ddbf0f9:

  bcachefs: bch2_bkey_sectors_need_rebalance() now only depends on bch_extent_rebalance (2025-02-06 22:35:11 -0500)

----------------------------------------------------------------
bcachefs fixes for 6.14-rc2

- add a SubmittingPatches to clarify that patches submitted for bcachefs
  do, in fact, need to be tested
- discard path now correctly issues journal flushes when needed, this
  fixes performance issues when the filesystem is nearly full and we're
  bottlenecked on copygc
- fix a bug that could cause the pending rebalance work accounting to be
  off when devices are being onlined/offlined; users should report if
  they are still seeing this
- and a few more trivial ones

----------------------------------------------------------------
Jeongjun Park (2):
      bcachefs: fix incorrect pointer check in __bch2_subvolume_delete()
      bcachefs: fix deadlock in journal_entry_open()

Kent Overstreet (4):
      bcachefs docs: SubmittingPatches.rst
      bcachefs: Fix discard path journal flushing
      bcachefs: Fix rcu imbalance in bch2_fs_btree_key_cache_exit()
      bcachefs: bch2_bkey_sectors_need_rebalance() now only depends on bch_extent_rebalance

 .../filesystems/bcachefs/SubmittingPatches.rst     | 98 ++++++++++++++++++++++
 Documentation/filesystems/bcachefs/index.rst       |  1 +
 MAINTAINERS                                        |  1 +
 fs/bcachefs/alloc_background.c                     | 47 ++++++-----
 fs/bcachefs/alloc_foreground.c                     | 10 ++-
 fs/bcachefs/alloc_types.h                          |  1 +
 fs/bcachefs/btree_key_cache.c                      |  1 -
 fs/bcachefs/buckets_waiting_for_journal.c          | 12 ++-
 fs/bcachefs/buckets_waiting_for_journal.h          |  4 +-
 fs/bcachefs/inode.h                                |  4 +-
 fs/bcachefs/journal.c                              | 18 +++-
 fs/bcachefs/journal.h                              |  1 +
 fs/bcachefs/journal_types.h                        |  1 +
 fs/bcachefs/opts.h                                 | 14 ----
 fs/bcachefs/rebalance.c                            |  8 +-
 fs/bcachefs/rebalance.h                            | 20 +++++
 fs/bcachefs/subvolume.c                            |  7 +-
 fs/bcachefs/super.c                                | 11 +++
 fs/bcachefs/super.h                                |  1 +
 fs/bcachefs/trace.h                                | 14 +++-
 20 files changed, 215 insertions(+), 59 deletions(-)
 create mode 100644 Documentation/filesystems/bcachefs/SubmittingPatches.rst
pr-tracker-bot@kernel.org Feb. 7, 2025, 10:25 p.m. UTC | #3
The pull request you sent on Thu, 6 Feb 2025 22:41:47 -0500:

> git://evilpiepirate.org/bcachefs.git tags/bcachefs-2025-02-06.2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/94b481f7671f412b571e4ee5e3b24f33a889812d

Thank you!