From patchwork Fri Aug 11 12:08:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Przemek Kitszel X-Patchwork-Id: 13350761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53708C0015E for ; Fri, 11 Aug 2023 12:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233980AbjHKMLN (ORCPT ); Fri, 11 Aug 2023 08:11:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231195AbjHKMLM (ORCPT ); Fri, 11 Aug 2023 08:11:12 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D1CB125; Fri, 11 Aug 2023 05:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691755872; x=1723291872; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8/1czmXTxvJiNdV0KCrkKInWq94tNZWJUyJzCScYHkY=; b=K9LX1mQWCIwsYaW49uTRv+xcfU/K6QlqzkNA8ft+wyVEww1AdMKp7SsJ nAgnW4wHNHwJLxRU9F+Xo91I/8on+N6Ov7rt9OByH86E5BNsszWdGXoTo NI5Hz4wNRMSwMYN/SMGr+EF1RdAUCkNzRHBBw2wsIPYbhB9qQAzmwzvQB G3p84b5oAVEgYKCa6g4jvPFuOTS2xBxbq2E5YIfAJaKI8TlD2v0xIwyoT 6d/2T00aIWa71waW0ING6XNJw5VD5CxGJzxJup2zfP7S8dsK4AMSk/gxx L8AnNBWUc8RWRY4dSPkyxko8SizTgXdh3LwLq6MqwYEKXlcbFXybwYqH3 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="435557382" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="435557382" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 05:11:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="979222045" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="979222045" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2023 05:11:08 -0700 Received: from pelor.igk.intel.com (pelor.igk.intel.com [10.123.220.13]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 90081312F6; Fri, 11 Aug 2023 13:11:07 +0100 (IST) From: Przemek Kitszel To: Kees Cook , netdev@vger.kernel.org Cc: Jacob Keller , intel-wired-lan@lists.osuosl.org, Alexander Lobakin , linux-hardening@vger.kernel.org, Steven Zou , Przemek Kitszel Subject: [PATCH net-next v2 0/7] introduce DEFINE_FLEX() macro Date: Fri, 11 Aug 2023 08:08:07 -0400 Message-Id: <20230811120814.169952-1-przemyslaw.kitszel@intel.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Add DEFINE_FLEX() macro, that helps on-stack allocation of structures with trailing flex array member. Expose __struct_size() macro which reads size of data allocated by DEFINE_FLEX(). Accompany new macros introduction with actual usage, in the ice driver (hence targeting for netdev tree). Obvious benefits include simpler resulting code, less heap usage, less error checking. Less obvious is the fact that compiler has more room to optimize, and as a whole, even with more stuff on the stack, we end up with overall better (smaller) report from bloat-o-meter: add/remove: 8/6 grow/shrink: 7/18 up/down: 2211/-2270 (-59) (individual results in each patch). v2: Kees: reusing __struct_size() instead of doubling it as a new macro Przemek Kitszel (7): overflow: add DEFINE_FLEX() for on-stack allocs ice: ice_sched_remove_elems: replace 1 elem array param by u32 ice: drop two params of ice_aq_move_sched_elems() ice: make use of DEFINE_FLEX() in ice_ddp.c ice: make use of DEFINE_FLEX() for struct ice_aqc_add_tx_qgrp ice: make use of DEFINE_FLEX() for struct ice_aqc_dis_txq_item ice: make use of DEFINE_FLEX() in ice_switch.c drivers/net/ethernet/intel/ice/ice_common.c | 20 ++----- drivers/net/ethernet/intel/ice/ice_ddp.c | 39 ++++--------- drivers/net/ethernet/intel/ice/ice_lag.c | 48 ++++------------ drivers/net/ethernet/intel/ice/ice_lib.c | 23 ++------ drivers/net/ethernet/intel/ice/ice_sched.c | 56 ++++++------------ drivers/net/ethernet/intel/ice/ice_sched.h | 6 +- drivers/net/ethernet/intel/ice/ice_switch.c | 63 +++++---------------- drivers/net/ethernet/intel/ice/ice_xsk.c | 22 +++---- include/linux/compiler_types.h | 12 ++++ include/linux/fortify-string.h | 4 -- include/linux/overflow.h | 27 +++++++++ 11 files changed, 113 insertions(+), 207 deletions(-) base-commit: 6a1ed1430daa2ccf8ac457e0db93fb0925b801ca