mbox series

[v4,0/3] overflow: Introduce wrapping helpers

Message ID 20240206102354.make.081-kees@kernel.org (mailing list archive)
Headers show
Series overflow: Introduce wrapping helpers | expand

Message

Kees Cook Feb. 6, 2024, 10:31 a.m. UTC 
v4:
 - use __builtin directly (marco)
 - rename to wrapping_* (eric)
 - update kern-doc (rasmus)
v3: https://lore.kernel.org/all/20240205090854.make.507-kees@kernel.org/
v2: https://lore.kernel.org/all/20240130220218.it.154-kees@kernel.org/
v1: https://lore.kernel.org/lkml/20240129182845.work.694-kees@kernel.org/

Hi,

In preparation for gaining instrumentation for signed[1], unsigned[2], and
pointer[3] wrap-around, expand the overflow header to include wrap-around
helpers that can be used to annotate arithmetic where wrapped calculations
are expected (e.g. atomics).

After spending time getting the unsigned integer wrap-around sanitizer
running warning-free on a basic x86_64 boot[4], I think the add/sub/mul
helpers first argument being the output type makes the most sense (as
suggested by Rasmus).

-Kees

Link: https://github.com/KSPP/linux/issues/26 [1]
Link: https://github.com/KSPP/linux/issues/27 [2]
Link: https://github.com/KSPP/linux/issues/344 [3]
Link: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=devel/overflow/enable-unsigned-sanitizer [4]

Kees Cook (3):
  overflow: Adjust check_*_overflow() kern-doc to reflect results
  overflow: Introduce wrapping_add(), wrapping_sub(), and wrapping_mul()
  overflow: Introduce wrapping_inc() and wrapping_dec()

 include/linux/overflow.h | 104 ++++++++++++++++++++++++++++++++++-----
 lib/overflow_kunit.c     |  67 +++++++++++++++++++++++--
 2 files changed, 155 insertions(+), 16 deletions(-)