mbox series

[v2,0/2] string: Convert selftests to KUnit

Message ID 20240301002416.it.092-kees@kernel.org (mailing list archive)
Headers show
Series string: Convert selftests to KUnit | expand

Message

Kees Cook March 1, 2024, 12:26 a.m. UTC 
Hi,

I realized the string selftests hadn't been converted to KUnit yet. Do that.

-Kees

 v2: rebase onto https://lore.kernel.org/r/20240229205345.93902-1-andriy.shevchenko@linux.intel.com
 v1: https://lore.kernel.org/linux-hardening/20240229233432.work.675-kees@kernel.org/

Kees Cook (2):
  string: Convert selftest to KUnit
  string: Convert helpers selftest to KUnit

 MAINTAINERS                                   |   4 +-
 lib/Kconfig.debug                             |  12 +-
 lib/Makefile                                  |   4 +-
 ...tring_helpers.c => string_helpers_kunit.c} | 177 ++++++++++--------
 lib/{test_string.c => string_kunit.c}         | 166 ++++++----------
 5 files changed, 164 insertions(+), 199 deletions(-)
 rename lib/{test-string_helpers.c => string_helpers_kunit.c} (78%)
 rename lib/{test_string.c => string_kunit.c} (54%)

Comments

Andy Shevchenko March 1, 2024, 11:22 a.m. UTC | #1 
On Fri, Mar 1, 2024 at 2:26 AM Kees Cook <keescook@chromium.org> wrote:
>
> Hi,
>
> I realized the string selftests hadn't been converted to KUnit yet. Do that.

IIRC last time somebody wanted to do that KUnit was completely sucking
in supporting the cases we need in these files. (I mean proper
messaging when we need to dump the expected and resulting data). And
please Cc Rasmus as well.