mbox series

[v3,0/2] string: Add load_unaligned_zeropad() code path to sized_strscpy()

Message ID 20250325015617.23455-1-pcc@google.com (mailing list archive)
Headers show
Series string: Add load_unaligned_zeropad() code path to sized_strscpy() | expand

Message

Peter Collingbourne March 25, 2025, 1:56 a.m. UTC 
This series fixes an issue where strscpy() would sometimes trigger
a false positive KASAN report with MTE.

v3:
- simplify test case

Peter Collingbourne (1):
  string: Add load_unaligned_zeropad() code path to sized_strscpy()

Vincenzo Frascino (1):
  kasan: Add strscpy() test to trigger tag fault on arm64

 lib/string.c            | 13 ++++++++++---
 mm/kasan/kasan_test_c.c | 13 +++++++++++++
 2 files changed, 23 insertions(+), 3 deletions(-)

Comments

Kees Cook March 25, 2025, 7:43 p.m. UTC | #1 
On Mon, Mar 24, 2025 at 06:56:13PM -0700, Peter Collingbourne wrote:
> This series fixes an issue where strscpy() would sometimes trigger
> a false positive KASAN report with MTE.

Thanks! Should this go via string API (me) or KASAN?

-Kees
Peter Collingbourne March 26, 2025, 5:12 p.m. UTC | #2 
On Tue, Mar 25, 2025 at 12:43 PM Kees Cook <kees@kernel.org> wrote:
>
> On Mon, Mar 24, 2025 at 06:56:13PM -0700, Peter Collingbourne wrote:
> > This series fixes an issue where strscpy() would sometimes trigger
> > a false positive KASAN report with MTE.
>
> Thanks! Should this go via string API (me) or KASAN?

Let's take this via string API.

Peter