| Message ID | 20250408142425.95437-1-ericwouds@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add nf_flow_encap_push() for xmit direct | expand |
Hi, Please, one series at a time. You pick a good target to start with. I already provided a few suggestions on where to start from. Thanks. On Tue, Apr 08, 2025 at 04:24:23PM +0200, Eric Woudstra wrote: > Patch to add nf_flow_encap_push(), see patch message. > > Added patch to eliminate array of flexible structures warning. > > Changed in v11: > - Only push when tuple.out.ifidx == tuple.out.hw_ifidx > - No changes in nft_dev_path_info() > > v10 split from patch-set: bridge-fastpath and related improvements v9 > > Eric Woudstra (2): > net: pppoe: avoid zero-length arrays in struct pppoe_hdr > netfilter: nf_flow_table_offload: Add nf_flow_encap_push() for xmit > direct > > drivers/net/ppp/pppoe.c | 2 +- > include/uapi/linux/if_pppox.h | 4 ++ > net/netfilter/nf_flow_table_ip.c | 97 +++++++++++++++++++++++++++++++- > 3 files changed, 100 insertions(+), 3 deletions(-) > > -- > 2.47.1 >
On 4/8/25 6:02 PM, Pablo Neira Ayuso wrote: > Hi, > > Please, one series at a time. You pick a good target to start with. > > I already provided a few suggestions on where to start from. > Ok, I view the patch-set 'conntrack: bridge: add double vlan, pppoe and pppoe-in-q' more as an added bonus to the bridge-fastpath. It is quite separate from the rest. I would consider this patch-set as low priority. May I suggest we focus on patch-sets: 'Add nf_flow_encap_push() for xmit direct' and 'netfilter: fastpath fixes' After these issues are addressed, only then it makes sense to add patch-set: 'netfilter: Add bridge-fastpath'. Thanks
Patch to add nf_flow_encap_push(), see patch message. Added patch to eliminate array of flexible structures warning. Changed in v11: - Only push when tuple.out.ifidx == tuple.out.hw_ifidx - No changes in nft_dev_path_info() v10 split from patch-set: bridge-fastpath and related improvements v9 Eric Woudstra (2): net: pppoe: avoid zero-length arrays in struct pppoe_hdr netfilter: nf_flow_table_offload: Add nf_flow_encap_push() for xmit direct drivers/net/ppp/pppoe.c | 2 +- include/uapi/linux/if_pppox.h | 4 ++ net/netfilter/nf_flow_table_ip.c | 97 +++++++++++++++++++++++++++++++- 3 files changed, 100 insertions(+), 3 deletions(-)