From patchwork Thu Oct 20 10:25:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Reshetova, Elena" X-Patchwork-Id: 9386529 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 596FF607D0 for ; Thu, 20 Oct 2016 10:28:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49D51292BF for ; Thu, 20 Oct 2016 10:28:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E0D9292DC; Thu, 20 Oct 2016 10:28:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.wl.linuxfoundation.org (Postfix) with SMTP id E9628292BF for ; Thu, 20 Oct 2016 10:28:37 +0000 (UTC) Received: (qmail 3899 invoked by uid 550); 20 Oct 2016 10:26:26 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: kernel-hardening@lists.openwall.com Delivered-To: mailing list kernel-hardening@lists.openwall.com Received: (qmail 3712 invoked from network); 20 Oct 2016 10:26:22 -0000 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,518,1473145200"; d="scan'208";a="181819651" From: Elena Reshetova To: kernel-hardening@lists.openwall.com Cc: keescook@chromium.org, Hans Liljestrand , Elena Reshetova , David Windsor Date: Thu, 20 Oct 2016 13:25:31 +0300 Message-Id: <1476959131-6153-14-git-send-email-elena.reshetova@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1476959131-6153-1-git-send-email-elena.reshetova@intel.com> References: <1476959131-6153-1-git-send-email-elena.reshetova@intel.com> Subject: [kernel-hardening] [RFC v2 PATCH 13/13] lkdtm: add tests for atomic over-/underflow X-Virus-Scanned: ClamAV using ClamSMTP From: Hans Liljestrand This adds additional tests for modified atomic functions. Signed-off-by: Hans Liljestrand Signed-off-by: Elena Reshetova Signed-off-by: David Windsor --- drivers/misc/lkdtm.h | 17 +++++++ drivers/misc/lkdtm_bugs.c | 122 +++++++++++++++++++++++++++++++++++++++------- drivers/misc/lkdtm_core.c | 17 +++++++ 3 files changed, 138 insertions(+), 18 deletions(-) diff --git a/drivers/misc/lkdtm.h b/drivers/misc/lkdtm.h index cfa1039..224713a 100644 --- a/drivers/misc/lkdtm.h +++ b/drivers/misc/lkdtm.h @@ -20,7 +20,24 @@ void lkdtm_HARDLOCKUP(void); void lkdtm_SPINLOCKUP(void); void lkdtm_HUNG_TASK(void); void lkdtm_ATOMIC_UNDERFLOW(void); +void lkdtm_ATOMIC_DEC_RETURN_UNDERFLOW(void); +void lkdtm_ATOMIC_SUB_UNDERFLOW(void); +void lkdtm_ATOMIC_SUB_RETURN_UNDERFLOW(void); void lkdtm_ATOMIC_OVERFLOW(void); +void lkdtm_ATOMIC_INC_RETURN_OVERFLOW(void); +void lkdtm_ATOMIC_ADD_OVERFLOW(void); +void lkdtm_ATOMIC_ADD_RETURN_OVERFLOW(void); +void lkdtm_ATOMIC_ADD_UNLESS_OVERFLOW(void); +void lkdtm_ATOMIC_INC_AND_TEST_OVERFLOW(void); +void lkdtm_ATOMIC_LONG_UNDERFLOW(void); +void lkdtm_ATOMIC_LONG_DEC_RETURN_UNDERFLOW(void); +void lkdtm_ATOMIC_LONG_SUB_UNDERFLOW(void); +void lkdtm_ATOMIC_LONG_SUB_RETURN_UNDERFLOW(void); +void lkdtm_ATOMIC_LONG_OVERFLOW(void); +void lkdtm_ATOMIC_LONG_INC_RETURN_OVERFLOW(void); +void lkdtm_ATOMIC_LONG_ADD_OVERFLOW(void); +void lkdtm_ATOMIC_LONG_ADD_RETURN_OVERFLOW(void); +void lkdtm_ATOMIC_LONG_SUB_AND_TEST(void); void lkdtm_CORRUPT_LIST_ADD(void); void lkdtm_CORRUPT_LIST_DEL(void); diff --git a/drivers/misc/lkdtm_bugs.c b/drivers/misc/lkdtm_bugs.c index f336206..bd79a88 100644 --- a/drivers/misc/lkdtm_bugs.c +++ b/drivers/misc/lkdtm_bugs.c @@ -128,30 +128,116 @@ void lkdtm_HUNG_TASK(void) schedule(); } -void lkdtm_ATOMIC_UNDERFLOW(void) -{ - atomic_t under = ATOMIC_INIT(INT_MIN); - - pr_info("attempting good atomic increment\n"); - atomic_inc(&under); - atomic_dec(&under); - - pr_info("attempting bad atomic underflow\n"); - atomic_dec(&under); +#define ATOMIC_LKDTM_MIN(tag,fun) void lkdtm_ATOMIC_##tag(void) \ +{ \ + atomic_t atomic = ATOMIC_INIT(INT_MIN); \ + \ + pr_info("attempting good atomic_" #fun "\n"); \ + atomic_inc(&atomic); \ + TEST_FUNC(&atomic); \ + \ + pr_info("attempting bad atomic_" #fun "\n"); \ + TEST_FUNC(&atomic); \ } -void lkdtm_ATOMIC_OVERFLOW(void) -{ - atomic_t over = ATOMIC_INIT(INT_MAX); +#define ATOMIC_LKDTM_MAX(tag,fun,...) \ +void lkdtm_ATOMIC_##tag(void) \ +{ \ + atomic_t atomic = ATOMIC_INIT(INT_MAX); \ + \ + pr_info("attempting good atomic_" #fun "\n"); \ + atomic_dec(&atomic); \ + TEST_FUNC(&atomic); \ + \ + pr_info("attempting bad atomic_" #fun "\n"); \ + TEST_FUNC(&atomic); \ +} - pr_info("attempting good atomic decrement\n"); - atomic_dec(&over); - atomic_inc(&over); +#define ATOMIC_LKDTM_LONG_MIN(tag,fun,...) \ +void lkdtm_ATOMIC_LONG_##tag(void) \ +{ \ + atomic_long_t atomic = ATOMIC_LONG_INIT(LONG_MIN); \ + \ + pr_info("attempting good atomic_long_" #fun "\n"); \ + atomic_long_inc(&atomic); \ + TEST_FUNC(&atomic); \ + \ + pr_info("attempting bad atomic_long_" #fun "\n"); \ + TEST_FUNC(&atomic); \ +} - pr_info("attempting bad atomic overflow\n"); - atomic_inc(&over); +#define ATOMIC_LKDTM_LONG_MAX(tag,fun,...) \ +void lkdtm_ATOMIC_LONG_##tag(void) \ +{ \ + atomic_long_t atomic = ATOMIC_LONG_INIT(LONG_MAX); \ + \ + pr_info("attempting good atomic_long_" #fun "\n"); \ + atomic_long_dec(&atomic); \ + TEST_FUNC(&atomic); \ + \ + pr_info("attempting bad atomic_long_" #fun "\n"); \ + TEST_FUNC(&atomic); \ } +#define TEST_FUNC(x) atomic_dec(x) +ATOMIC_LKDTM_MIN(UNDERFLOW,dec) +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_dec_return(x) +ATOMIC_LKDTM_MIN(DEC_RETURN_UNDERFLOW,dec_return); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_sub(1,x) +ATOMIC_LKDTM_MIN(SUB_UNDERFLOW,sub); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_sub_return(1,x); +ATOMIC_LKDTM_MIN(SUB_RETURN_UNDERFLOW,sub_return); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_inc(x); +ATOMIC_LKDTM_MAX(OVERFLOW,inc); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_inc_return(x); +ATOMIC_LKDTM_MAX(INC_RETURN_OVERFLOW,inc_return); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_add(1,x); +ATOMIC_LKDTM_MAX(ADD_OVERFLOW,add); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_add_return(1,x); +ATOMIC_LKDTM_MAX(ADD_RETURN_OVERFLOW,add_return); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_add_unless(x,1,0); +ATOMIC_LKDTM_MAX(ADD_UNLESS_OVERFLOW,add_unless); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_inc_and_test(x); +ATOMIC_LKDTM_MAX(INC_AND_TEST_OVERFLOW,inc_and_test); +#undef TEST_FUNC + +#define TEST_FUNC(x) atomic_long_dec(x); +ATOMIC_LKDTM_LONG_MIN(UNDERFLOW,dec); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_long_dec_return(x); +ATOMIC_LKDTM_LONG_MIN(DEC_RETURN_UNDERFLOW,dec_return); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_long_sub(1,x); +ATOMIC_LKDTM_LONG_MIN(SUB_UNDERFLOW,sub); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_long_sub_return(1,x); +ATOMIC_LKDTM_LONG_MIN(SUB_RETURN_UNDERFLOW,sub_return); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_long_inc(x); +ATOMIC_LKDTM_LONG_MAX(OVERFLOW,inc); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_long_inc_return(x); +ATOMIC_LKDTM_LONG_MAX(INC_RETURN_OVERFLOW,inc_return); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_long_add(1,x); +ATOMIC_LKDTM_LONG_MAX(ADD_OVERFLOW,add); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_long_add_return(1,x); +ATOMIC_LKDTM_LONG_MAX(ADD_RETURN_OVERFLOW,add_return); +#undef TEST_FUNC +#define TEST_FUNC(x) atomic_long_sub_and_test(1,x); +ATOMIC_LKDTM_LONG_MIN(SUB_AND_TEST,sub_and_test); +#undef TEST_FUNC + void lkdtm_CORRUPT_LIST_ADD(void) { /* diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c index 7eeb71a..4b05803 100644 --- a/drivers/misc/lkdtm_core.c +++ b/drivers/misc/lkdtm_core.c @@ -221,7 +221,24 @@ struct crashtype crashtypes[] = { CRASHTYPE(WRITE_RO_AFTER_INIT), CRASHTYPE(WRITE_KERN), CRASHTYPE(ATOMIC_UNDERFLOW), + CRASHTYPE(ATOMIC_DEC_RETURN_UNDERFLOW), + CRASHTYPE(ATOMIC_SUB_UNDERFLOW), + CRASHTYPE(ATOMIC_SUB_RETURN_UNDERFLOW), CRASHTYPE(ATOMIC_OVERFLOW), + CRASHTYPE(ATOMIC_INC_RETURN_OVERFLOW), + CRASHTYPE(ATOMIC_ADD_OVERFLOW), + CRASHTYPE(ATOMIC_ADD_RETURN_OVERFLOW), + CRASHTYPE(ATOMIC_ADD_UNLESS_OVERFLOW), + CRASHTYPE(ATOMIC_INC_AND_TEST_OVERFLOW), + CRASHTYPE(ATOMIC_LONG_UNDERFLOW), + CRASHTYPE(ATOMIC_LONG_DEC_RETURN_UNDERFLOW), + CRASHTYPE(ATOMIC_LONG_SUB_UNDERFLOW), + CRASHTYPE(ATOMIC_LONG_SUB_RETURN_UNDERFLOW), + CRASHTYPE(ATOMIC_LONG_OVERFLOW), + CRASHTYPE(ATOMIC_LONG_INC_RETURN_OVERFLOW), + CRASHTYPE(ATOMIC_LONG_ADD_OVERFLOW), + CRASHTYPE(ATOMIC_LONG_ADD_RETURN_OVERFLOW), + CRASHTYPE(ATOMIC_LONG_SUB_AND_TEST), CRASHTYPE(USERCOPY_HEAP_SIZE_TO), CRASHTYPE(USERCOPY_HEAP_SIZE_FROM), CRASHTYPE(USERCOPY_HEAP_FLAG_TO),