From patchwork Tue Jun 6 00:51:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 9767759 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DB0A46034B for ; Tue, 6 Jun 2017 00:52:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFAC227968 for ; Tue, 6 Jun 2017 00:52:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C29FE283C0; Tue, 6 Jun 2017 00:52:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.wl.linuxfoundation.org (Postfix) with SMTP id CF54D27968 for ; Tue, 6 Jun 2017 00:52:42 +0000 (UTC) Received: (qmail 19906 invoked by uid 550); 6 Jun 2017 00:52:09 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Delivered-To: mailing list kernel-hardening@lists.openwall.com Received: (qmail 18424 invoked from network); 6 Jun 2017 00:52:04 -0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references; s=mail; bh=1yJL ns3WB1X559vpcGA+HBeZM+0=; b=B+A9kHNRx6f17QG+Np+6kAq+OlBBhmEA8dV9 Lxk7WzXwDzB7bZ3xba4sMQCC9XG8I6AOPH5Lu6oj5lCuIqRsZGjU4dTaWEcaTz0J o4wZSWipvNmysCRuCDzYOiATOtqIUvESu2ojo25aZo+496sSBhIrAh2GnR+koypa +5uMk0VkF2wADIGT8NpX5HH0dCyyCOn2Z/Ch1FnfUzmrXhWnhazmzgn16U7Tw1oN 404cTyf4LlRd7yaQ1FwKemtk1zbdqwhyB5JUjSeBllv8lU6VwFFVm9sznz+VmQd8 seSgggl+mJQdF8xi516H4IUUpayEUo8C1DLpG+pbcHloW1+NJA== From: "Jason A. Donenfeld" To: Theodore Ts'o , Linux Crypto Mailing List , LKML , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , David Miller Cc: "Jason A. Donenfeld" Date: Tue, 6 Jun 2017 02:51:06 +0200 Message-Id: <20170606005108.5646-12-Jason@zx2c4.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170606005108.5646-1-Jason@zx2c4.com> References: <20170606005108.5646-1-Jason@zx2c4.com> Subject: [kernel-hardening] [PATCH v3 11/13] net/route: use get_random_int for random counter X-Virus-Scanned: ClamAV using ClamSMTP Using get_random_int here is faster, more fitting of the use case, and just as cryptographically secure. It also has the benefit of providing better randomness at early boot, which is when many of these structures are assigned. Also, semantically, it's not really proper to have been assigning an atomic_t in this way before, even if in practice it works fine. Signed-off-by: Jason A. Donenfeld Cc: David Miller --- net/ipv4/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 655d9eebe43e..11e001a42094 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2936,8 +2936,7 @@ static __net_init int rt_genid_init(struct net *net) { atomic_set(&net->ipv4.rt_genid, 0); atomic_set(&net->fnhe_genid, 0); - get_random_bytes(&net->ipv4.dev_addr_genid, - sizeof(net->ipv4.dev_addr_genid)); + atomic_set(&net->ipv4.dev_addr_genid, get_random_int()); return 0; }