| Message ID | 20181023213504.28905-4-igor.stoppa@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | prmem: protected memory | expand |
On 10/23/18 2:34 PM, Igor Stoppa wrote: > +#define VM_PMALLOC 0x00000100 /* pmalloc area - see docs */ > +#define VM_PMALLOC_WR 0x00000200 /* pmalloc write rare area */ > +#define VM_PMALLOC_PROTECTED 0x00000400 /* pmalloc protected area */ Please introduce things as you use them. It's impossible to review a patch that just says "see docs" that doesn't contain any docs. :)
On 25/10/2018 01:26, Dave Hansen wrote: > On 10/23/18 2:34 PM, Igor Stoppa wrote: >> +#define VM_PMALLOC 0x00000100 /* pmalloc area - see docs */ >> +#define VM_PMALLOC_WR 0x00000200 /* pmalloc write rare area */ >> +#define VM_PMALLOC_PROTECTED 0x00000400 /* pmalloc protected area */ > > Please introduce things as you use them. It's impossible to review a > patch that just says "see docs" that doesn't contain any docs. :) Yes, otoh it's a big pain in the neck to keep the docs split into smaller patches interleaved with the code, at least while the code is still in a flux. And since the docs refer to the sources, for the automated documentation of the API, I cannot just put the documentation at the beginning of the patchset. Can I keep the docs as they are, for now, till the code is more stable? -- igor
diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h index 398e9c95cd61..4d14a3b8089e 100644 --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -21,6 +21,9 @@ struct notifier_block; /* in notifier.h */ #define VM_UNINITIALIZED 0x00000020 /* vm_struct is not fully initialized */ #define VM_NO_GUARD 0x00000040 /* don't add guard page */ #define VM_KASAN 0x00000080 /* has allocated kasan shadow memory */ +#define VM_PMALLOC 0x00000100 /* pmalloc area - see docs */ +#define VM_PMALLOC_WR 0x00000200 /* pmalloc write rare area */ +#define VM_PMALLOC_PROTECTED 0x00000400 /* pmalloc protected area */ /* bits [20..32] reserved for arch specific ioremap internals */ /* @@ -48,7 +51,13 @@ struct vmap_area { unsigned long flags; struct rb_node rb_node; /* address sorted rbtree */ struct list_head list; /* address sorted list */ - struct llist_node purge_list; /* "lazy purge" list */ + union { + struct llist_node purge_list; /* "lazy purge" list */ + struct { + struct vmap_area *next; + struct pmalloc_pool *pool; + }; + }; struct vm_struct *vm; struct rcu_head rcu_head; }; @@ -134,6 +143,7 @@ extern struct vm_struct *__get_vm_area_caller(unsigned long size, const void *caller); extern struct vm_struct *remove_vm_area(const void *addr); extern struct vm_struct *find_vm_area(const void *addr); +extern struct vmap_area *find_vmap_area(unsigned long addr); extern int map_vm_area(struct vm_struct *area, pgprot_t prot, struct page **pages); diff --git a/mm/vmalloc.c b/mm/vmalloc.c index a728fc492557..15850005fea5 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -742,7 +742,7 @@ static void free_unmap_vmap_area(struct vmap_area *va) free_vmap_area_noflush(va); } -static struct vmap_area *find_vmap_area(unsigned long addr) +struct vmap_area *find_vmap_area(unsigned long addr) { struct vmap_area *va;
Prepare vmalloc for: - tagging areas used for dynamic allocation of protected memory - supporting various tags, related to the property that an area might have - extrapolating the pool containing a given area - chaining the areas in each pool - extrapolating the area containing a given memory address NOTE: Since there is a list_head structure that is used only when disposing of the allocation (the field purge_list), there are two pointers for the take, before it comes the time of freeing the allocation. To avoid increasing the size of the vmap_area structure, instead of using a standard doubly linked list for tracking the chain of vmap_areas, only one pointer is spent for this purpose, in a single linked list, while the other is used to provide a direct connection to the parent pool. Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com> CC: Michal Hocko <mhocko@kernel.org> CC: Andrew Morton <akpm@linux-foundation.org> CC: Chintan Pandya <cpandya@codeaurora.org> CC: Joe Perches <joe@perches.com> CC: "Luis R. Rodriguez" <mcgrof@kernel.org> CC: Thomas Gleixner <tglx@linutronix.de> CC: Kate Stewart <kstewart@linuxfoundation.org> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Philippe Ombredanne <pombredanne@nexb.com> CC: linux-mm@kvack.org CC: linux-kernel@vger.kernel.org --- include/linux/vmalloc.h | 12 +++++++++++- mm/vmalloc.c | 2 +- 2 files changed, 12 insertions(+), 2 deletions(-)