| Message ID | 20200510020044.958018-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gcc-plugins: remove always false $(if ...) in Makefile | expand |
On Sun, May 10, 2020 at 11:00:44AM +0900, Masahiro Yamada wrote: > This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused > GCC_PLUGIN_SUBDIR"). > > $(if $(findstring /,$(p)),...) is always false because none of plugins > contains '/' in the file name. > > Clean up the code. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org>
On Sun, May 10, 2020 at 11:14 AM Kees Cook <keescook@chromium.org> wrote: > > On Sun, May 10, 2020 at 11:00:44AM +0900, Masahiro Yamada wrote: > > This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused > > GCC_PLUGIN_SUBDIR"). > > > > $(if $(findstring /,$(p)),...) is always false because none of plugins > > contains '/' in the file name. > > > > Clean up the code. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Reviewed-by: Kees Cook <keescook@chromium.org> > Applied to linux-kbuild.
diff --git a/scripts/gcc-plugins/Makefile b/scripts/gcc-plugins/Makefile index 80f354289eeb..4014ba7e2fbd 100644 --- a/scripts/gcc-plugins/Makefile +++ b/scripts/gcc-plugins/Makefile @@ -14,7 +14,7 @@ $(objtree)/$(obj)/randomize_layout_seed.h: FORCE $(call if_changed,create_randomize_layout_seed) targets = randomize_layout_seed.h randomize_layout_hash.h -hostcxxlibs-y := $(foreach p,$(GCC_PLUGIN),$(if $(findstring /,$(p)),,$(p))) +hostcxxlibs-y := $(GCC_PLUGIN) always-y := $(hostcxxlibs-y) $(foreach p,$(hostcxxlibs-y:%.so=%),$(eval $(p)-objs := $(p).o))
This is the remnant of commit c17d6179ad5a ("gcc-plugins: remove unused GCC_PLUGIN_SUBDIR"). $(if $(findstring /,$(p)),...) is always false because none of plugins contains '/' in the file name. Clean up the code. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- scripts/gcc-plugins/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)