[2/7] leaking_addresses: Always print a trailing newline

Commit Message

Peter Zijlstra Oct. 8, 2021, 11:15 a.m. UTC

From: Kees Cook <[e-mail]>

For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
next line, making things look corrupted.

Unconditionally remove the newline on input, and write it back out on
output.

[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/

Signed-off-by: Kees Cook <[e-mail]>
Signed-off-by: Peter Zijlstra (Intel) <[e-mail]>
---
 scripts/leaking_addresses.pl |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -455,8 +455,9 @@  sub parse_file
 
 	open my $fh, "<", $file or return;
 	while ( <$fh> ) {
+		chomp;
 		if (may_leak_address($_)) {
-			print $file . ': ' . $_;
+			printf("$file: $_\n");
 		}
 	}
 	close $fh;