diff mbox series

[3/7] proc: Use task_is_running() for wchan in /proc/$pid/stat

Message ID 20211008111626.211281780@infradead.org (mailing list archive)
State Mainlined
Headers show
Series wchan: Fix wchan support | expand

Commit Message

Peter Zijlstra Oct. 8, 2021, 11:15 a.m. UTC 
From: Kees Cook <keescook@chromium.org>

The implementations of get_wchan() can be expensive. The only information
imparted here is whether or not a process is currently blocked in the
scheduler (and even this doesn't need to be exact). Avoid doing the
heavy lifting of stack walking and just report that information by using
task_is_running().

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 fs/proc/array.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff mbox series

Patch

--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -541,7 +541,7 @@  static int do_task_stat(struct seq_file
 	}
 
 	if (permitted && (!whole || num_threads < 2))
-		wchan = get_wchan(task);
+		wchan = !task_is_running(task);
 	if (!whole) {
 		min_flt = task->min_flt;
 		maj_flt = task->maj_flt;
@@ -606,10 +606,7 @@  static int do_task_stat(struct seq_file
 	 *
 	 * This works with older implementations of procps as well.
 	 */
-	if (wchan)
-		seq_puts(m, " 1");
-	else
-		seq_puts(m, " 0");
+	seq_put_decimal_ull(m, " ", wchan);
 
 	seq_put_decimal_ull(m, " ", 0);
 	seq_put_decimal_ull(m, " ", 0);