diff mbox series

[1/3] soc: qcom: pmic_glink: enable UCSI for SM8350

Message ID 20230806-xiaomi-star-v1-1-0c384e8b5737@gmail.com (mailing list archive)
State Handled Elsewhere
Headers show
Series Add initial support for Xiaomi Mi 11 Ultra | expand

Commit Message

Xilin Wu via B4 Relay Aug. 5, 2023, 5:03 p.m. UTC 
From: Xilin Wu <wuxilin123@gmail.com>

UCSI is supported on SM8350. Allow it to enable USB role switch and
altmode notifications on SM8350.

Signed-off-by: Xilin Wu <wuxilin123@gmail.com>
---
 drivers/soc/qcom/pmic_glink.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Konrad Dybcio Aug. 12, 2023, 11:12 a.m. UTC | #1 
On 5.08.2023 19:03, Xilin Wu via B4 Relay wrote:
> From: Xilin Wu <wuxilin123@gmail.com>
> 
> UCSI is supported on SM8350. Allow it to enable USB role switch and
> altmode notifications on SM8350.
> 
> Signed-off-by: Xilin Wu <wuxilin123@gmail.com>
> ---
I can confirm this is also required for my SM8350 Xperia 1 III.

You will however need to rebase this patch atop next, sm8550_client_mask
no longer exists.

Konrad
Dmitry Baryshkov Aug. 13, 2023, 10:56 a.m. UTC | #2 
On Sat, 12 Aug 2023 at 14:12, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 5.08.2023 19:03, Xilin Wu via B4 Relay wrote:
> > From: Xilin Wu <wuxilin123@gmail.com>
> >
> > UCSI is supported on SM8350. Allow it to enable USB role switch and
> > altmode notifications on SM8350.
> >
> > Signed-off-by: Xilin Wu <wuxilin123@gmail.com>
> > ---
> I can confirm this is also required for my SM8350 Xperia 1 III.

Last time I checked it, UCSI was broken on the SM8350 HDK. Trying to
enable it caused pmic_glink to stop working after some port
operations.
Xilin Wu Aug. 14, 2023, 5:28 a.m. UTC | #3 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> 于2023年8月13日周日 18:56写道：
>
> On Sat, 12 Aug 2023 at 14:12, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> >
> > On 5.08.2023 19:03, Xilin Wu via B4 Relay wrote:
> > > From: Xilin Wu <wuxilin123@gmail.com>
> > >
> > > UCSI is supported on SM8350. Allow it to enable USB role switch and
> > > altmode notifications on SM8350.
> > >
> > > Signed-off-by: Xilin Wu <wuxilin123@gmail.com>
> > > ---
> > I can confirm this is also required for my SM8350 Xperia 1 III.
>
> Last time I checked it, UCSI was broken on the SM8350 HDK. Trying to
> enable it caused pmic_glink to stop working after some port
> operations.

I guess it could be firmware related issues? It works fine on my
device with latest firmware.
diff mbox series

Patch

diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c
index c87056769ebd..0f8ac55ec2ac 100644
--- a/drivers/soc/qcom/pmic_glink.c
+++ b/drivers/soc/qcom/pmic_glink.c
@@ -347,6 +347,7 @@  static const unsigned long pmic_glink_sm8550_client_mask = BIT(PMIC_GLINK_CLIENT
 							   BIT(PMIC_GLINK_CLIENT_UCSI);
 
 static const struct of_device_id pmic_glink_of_match[] = {
+	{ .compatible = "qcom,sm8350-pmic-glink", .data = &pmic_glink_sm8450_client_mask },
 	{ .compatible = "qcom,sm8450-pmic-glink", .data = &pmic_glink_sm8450_client_mask },
 	{ .compatible = "qcom,sm8550-pmic-glink", .data = &pmic_glink_sm8550_client_mask },
 	{ .compatible = "qcom,pmic-glink" },