| Message ID | 20230922175402.work.819-kees@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 6e6891ccf0c7e70f13bc1d5ce5a7edee2b5de045 |
| Headers | show |
| Series | regulator: mc13xxx: Annotate struct mc13xxx_regulator_priv with __counted_by | expand |
On Fri, 22 Sep 2023 10:54:02 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct mc13xxx_regulator_priv. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator: mc13xxx: Annotate struct mc13xxx_regulator_priv with __counted_by commit: 6e6891ccf0c7e70f13bc1d5ce5a7edee2b5de045 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Fri, Sep 22, 2023 at 10:54:02AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct mc13xxx_regulator_priv. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks -- Gustavo > --- > drivers/regulator/mc13xxx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/mc13xxx.h b/drivers/regulator/mc13xxx.h > index e03279dc43f4..057aaef6f086 100644 > --- a/drivers/regulator/mc13xxx.h > +++ b/drivers/regulator/mc13xxx.h > @@ -24,7 +24,7 @@ struct mc13xxx_regulator_priv { > u32 powermisc_pwgt_state; > struct mc13xxx_regulator *mc13xxx_regulators; > int num_regulators; > - struct regulator_dev *regulators[]; > + struct regulator_dev *regulators[] __counted_by(num_regulators); > }; > > extern int mc13xxx_fixed_regulator_set_voltage(struct regulator_dev *rdev, > -- > 2.34.1 > >
diff --git a/drivers/regulator/mc13xxx.h b/drivers/regulator/mc13xxx.h index e03279dc43f4..057aaef6f086 100644 --- a/drivers/regulator/mc13xxx.h +++ b/drivers/regulator/mc13xxx.h @@ -24,7 +24,7 @@ struct mc13xxx_regulator_priv { u32 powermisc_pwgt_state; struct mc13xxx_regulator *mc13xxx_regulators; int num_regulators; - struct regulator_dev *regulators[]; + struct regulator_dev *regulators[] __counted_by(num_regulators); }; extern int mc13xxx_fixed_regulator_set_voltage(struct regulator_dev *rdev,
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct mc13xxx_regulator_priv. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Signed-off-by: Kees Cook <keescook@chromium.org> --- drivers/regulator/mc13xxx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)