From patchwork Thu Sep 28 02:42:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuanhe Shu X-Patchwork-Id: 13401908 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A7D468A for ; Thu, 28 Sep 2023 02:43:54 +0000 (UTC) Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5FD294; Wed, 27 Sep 2023 19:43:51 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R741e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=xiangzao@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0Vt.rlIY_1695869028; Received: from localhost.localdomain(mailfrom:xiangzao@linux.alibaba.com fp:SMTPD_---0Vt.rlIY_1695869028) by smtp.aliyun-inc.com; Thu, 28 Sep 2023 10:43:49 +0800 From: Yuanhe Shu To: gregkh@linuxfoundation.org, jirislaby@kernel.org, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kselftest@vger.kernel.org, Yuanhe Shu , Xingrui Yi Subject: [PATCH 4/5] pstore: remove the module parameter "backend" Date: Thu, 28 Sep 2023 10:42:43 +0800 Message-Id: <20230928024244.257687-5-xiangzao@linux.alibaba.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230928024244.257687-1-xiangzao@linux.alibaba.com> References: <20230928024244.257687-1-xiangzao@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Since all enabled backends have corresponding subdir in /sys/fs/pstore, and the logic of finding unexpected is changed by using psinfo_list rather than parameter backend, it is not necessary to retain the parameter backend. Remove the unnecessary module parameter "backend". Signed-off-by: Xingrui Yi Signed-off-by: Yuanhe Shu --- fs/pstore/platform.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index d576ee48527c..90c33c1ca39f 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -77,10 +77,6 @@ static DECLARE_WORK(pstore_work, pstore_dowork); DEFINE_MUTEX(psback_lock); struct pstore_backends *psback; -static char *backend; -module_param(backend, charp, 0444); -MODULE_PARM_DESC(backend, "specific backend to use"); - static char *compress = #ifdef CONFIG_PSTORE_COMPRESS_DEFAULT CONFIG_PSTORE_COMPRESS_DEFAULT; @@ -675,12 +671,6 @@ int pstore_register(struct pstore_info *psi) /* Start watching for new records, if desired. */ pstore_timer_kick(); - /* - * Update the module parameter backend, so it is visible - * through /sys/module/pstore/parameters/backend - */ - backend = kstrdup(psi->name, GFP_KERNEL); - pr_info("Registered %s as persistent store backend\n", psi->name); mutex_unlock(&psback_lock);