From patchwork Mon Dec 18 18:44:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanzir Hasan X-Patchwork-Id: 13497371 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 840E65D74F for ; Mon, 18 Dec 2023 18:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tanzirh.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kdRfg4vt" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5e46cbc3d34so35851017b3.3 for ; Mon, 18 Dec 2023 10:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702925094; x=1703529894; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tpo/c9r9EIu18GNZd0zUoly513OzCu9h8vUVs3exmy8=; b=kdRfg4vtdbHrH77Muo04+CUpRJCDZ8Wx8IMxv3uLMTStndrGp9Wf2SnQhgnC46RTo4 tjdkiiN8e07YqRQJ5gO8WMOY81VQO9rc90cIJsctHRT8VpQQeFyDukOPC/Tesr5rHm58 RImSnvrTqUc2ors3VLu2o3xsKlxFekhWuOIjIrS4th2jzRhOOn2l/OFHVCd1yVzCk2rf mgbNfLeb758BBGTVz3d5yeZwPeG3c8lPiYkA5shsMsgtwsaTw7Kkuaz7zK5AjEG+Ifoe TKt/1gpISMPyHs9dSJuJQEW+3xvRp4CynaGdkzRRQzyTEHPF5yNnVZd+RE0f/yP3uT28 kjBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702925094; x=1703529894; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tpo/c9r9EIu18GNZd0zUoly513OzCu9h8vUVs3exmy8=; b=hcukIAG1N50pN+xEy3MHK10MopETxGig+4QgRq9IbdcDEJGlxKM1uV5gbe2HhZj8Rz XyiKWuyAgZFnhUU11+hIs7rw00y37VEp2iwZGdzvEt3Wqi31zD2mv0X0Pcmp99uvLZUU XAf3XrNU4RUL5LM2vbLV5+lcQS1MfIlCzTnucw1iqal/Ievtqqia+bIpP1s0XEvwn/4U kMXFKMFqJ9sp7ydV6n7akEddb2Z8WvwlgAz96CNX4k07gHL37BIcc56Khez8ACnnldTH JU/1u/X8Jn4qM0wNNbHuQcejYBE5LVNVrosJjgS7sFpRkkhNktiWCvKygBSJVV+6H+La qLHQ== X-Gm-Message-State: AOJu0YwcScQd93C4TIDVDhnscqPBrLDsg5JXHN4cFCDWW/i0iYRYJfjU iJJWYd/iFUQ6Jby2j/P937ooOY6qV7gT X-Google-Smtp-Source: AGHT+IEL+Dx1RotMvLWMcY1+5+NuvVxZsWdNSosBAVYxXmnwighAQ9gxwlp64utMUoi9SVx3v+rGiCMwFKtq X-Received: from tanz.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:c4a]) (user=tanzirh job=sendgmr) by 2002:a05:690c:f09:b0:5e6:27ee:67fb with SMTP id dc9-20020a05690c0f0900b005e627ee67fbmr1094009ywb.4.1702925094663; Mon, 18 Dec 2023 10:44:54 -0800 (PST) Date: Mon, 18 Dec 2023 18:44:48 +0000 In-Reply-To: <20231218-libstringheader-v3-0-500bd58f0f75@google.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231218-libstringheader-v3-0-500bd58f0f75@google.com> X-Developer-Key: i=tanzirh@google.com; a=ed25519; pk=UeRjcUcv5W9AeLGEbAe2+0LptQpcY+o1Zg0LHHo7VN4= X-Developer-Signature: v=1; a=ed25519-sha256; t=1702925089; l=1465; i=tanzirh@google.com; s=20231204; h=from:subject:message-id; bh=gV26WBhHZ984rQ1se1KmnC1yaoC0r21Ttaqbp2LY4BY=; b=jxTx/p2T2Ohx/6qrHcl3jtgDOOmwmAwnPNqfbYw6tFl7hSTnsJb4wAi6wJ+SdIgs/+BwK8LRr GBsNJwdWCtgBkIP7kkNwrDxrAz71X+t1oXylc5I7LWotslSU7lJgd2K X-Mailer: b4 0.12.3 Message-ID: <20231218-libstringheader-v3-2-500bd58f0f75@google.com> Subject: [PATCH v3 2/2] lib/string: shrink lib/string.i via IWYU From: tanzirh@google.com To: Kees Cook Cc: Andy Shevchenko , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Nick DeSaulniers , Andrew Morton , llvm@lists.linux.dev, Tanzir Hasan This diff uses an open source tool include-what-you-use (IWYU) to modify the include list changing indirect includes to direct includes. IWYU is implemented using the IWYUScripts github repository which is a tool that is currently undergoing development. These changes seek to improve build times. This change to lib/string.c resulted in a preprocessed size of lib/string.i from 26371 lines to 5263 lines (-80%) for the x86 defconfig. Link: https://github.com/ClangBuiltLinux/IWYUScripts Reviewed-by: Kees Cook Signed-off-by: Tanzir Hasan --- lib/string.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/string.c b/lib/string.c index be26623953d2..6e24a4967dd7 100644 --- a/lib/string.c +++ b/lib/string.c @@ -16,18 +16,18 @@ #define __NO_FORTIFY #include -#include -#include -#include -#include +#include #include #include -#include - +#include +#include +#include +#include #include -#include +#include #include #include +#include #ifndef __HAVE_ARCH_STRNCASECMP /**