| Message ID | 20240226055615.79195-1-raihan1999ahamed@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree | expand |
On 26/02/2024 06:55, Raihan Ahamed wrote: > Lenovo P2 is a handset using the MSM8953 SoC released in 2016 > > Add a device tree for with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - WCNSS (WiFi/BT) > - Regulators > > Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++ > 2 files changed, 241 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 39889d5f8e12..aebfb1ae728c 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8939-huawei-kiwi.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8939-longcheer-l9100.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8939-samsung-a7.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8939-sony-xperia-kanuti-tulip.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8953-lenovo-kuntao.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-mido.dtb > diff --git a/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts > new file mode 100644 > index 000000000000..2fd6345bbe15 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts > @@ -0,0 +1,240 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2024, Raihan Ahamed <raihan1999ahamed@gmail.com> > + */ > +/dts-v1/; > + > +#include "msm8953.dtsi" > +#include "pm8953.dtsi" > +#include "pmi8950.dtsi" > + > +/delete-node/ &qseecom_mem; > + > +/ { > + model = "Lenovo P2"; > + compatible = "lenovo,kuntao", "qcom,msm8953"; Missing bindings. Best regards, Krzysztof
On Mon, 26 Feb 2024 11:25:56 +0530, Raihan Ahamed wrote: > Lenovo P2 is a handset using the MSM8953 SoC released in 2016 > > Add a device tree for with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - WCNSS (WiFi/BT) > - Regulators > > Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++ > 2 files changed, 241 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts > My bot found new DT warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/msm8953-lenovo-kuntao.dtb' for 20240226055615.79195-1-raihan1999ahamed@gmail.com: arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: gpu@1c00000: clock-names:5: 'anyOf' conditional failed, one must be fixed: 'core' was expected 'iface' was expected 'mem' was expected 'mem_iface' was expected 'alt_mem_iface' was expected 'gfx3d' was expected 'rbbmtimer' was expected 'rbcpr' was expected from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml# arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: iommu@1c48000: compatible: 'oneOf' conditional failed, one must be fixed: 'qcom,msm8953-iommu' is not one of ['qcom,msm8976-iommu'] 'qcom,msm-iommu-v1' was expected from schema $id: http://devicetree.org/schemas/iommu/qcom,iommu.yaml#
I have checked with latest dtschema before sending version 3, it does not give anything related to gpu and iommu. On Mon, Feb 26, 2024 at 10:24 PM Rob Herring <robh@kernel.org> wrote: > > > On Mon, 26 Feb 2024 11:25:56 +0530, Raihan Ahamed wrote: > > Lenovo P2 is a handset using the MSM8953 SoC released in 2016 > > > > Add a device tree for with initial support for: > > > > - GPIO keys > > - SDHCI (internal and external storage) > > - USB Device Mode > > - WCNSS (WiFi/BT) > > - Regulators > > > > Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com> > > --- > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > .../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++ > > 2 files changed, 241 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts > > > > > My bot found new DT warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y qcom/msm8953-lenovo-kuntao.dtb' for 20240226055615.79195-1-raihan1999ahamed@gmail.com: > > arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: gpu@1c00000: clock-names:5: 'anyOf' conditional failed, one must be fixed: > 'core' was expected > 'iface' was expected > 'mem' was expected > 'mem_iface' was expected > 'alt_mem_iface' was expected > 'gfx3d' was expected > 'rbbmtimer' was expected > 'rbcpr' was expected > from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml# > arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: iommu@1c48000: compatible: 'oneOf' conditional failed, one must be fixed: > 'qcom,msm8953-iommu' is not one of ['qcom,msm8976-iommu'] > 'qcom,msm-iommu-v1' was expected > from schema $id: http://devicetree.org/schemas/iommu/qcom,iommu.yaml# > > > > >
On 27/02/2024 05:33, Raihan Ahamed wrote: > I have checked again with latest dtschema before sending version 3 it > doesn't give anything related to gpu and iommu At least the second warning looks real, but the error was already there - in the DTSI. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 39889d5f8e12..aebfb1ae728c 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8939-huawei-kiwi.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8939-longcheer-l9100.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8939-samsung-a7.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8939-sony-xperia-kanuti-tulip.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8953-lenovo-kuntao.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-mido.dtb diff --git a/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts new file mode 100644 index 000000000000..2fd6345bbe15 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts @@ -0,0 +1,240 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2024, Raihan Ahamed <raihan1999ahamed@gmail.com> + */ +/dts-v1/; + +#include "msm8953.dtsi" +#include "pm8953.dtsi" +#include "pmi8950.dtsi" + +/delete-node/ &qseecom_mem; + +/ { + model = "Lenovo P2"; + compatible = "lenovo,kuntao", "qcom,msm8953"; + chassis-type = "handset"; + qcom,msm-id = <0x125 0x00>; + qcom,board-id = <0x41 0x82b1 0x41 0x83b0>; + + gpio-keys { + compatible = "gpio-keys"; + + pinctrl-names = "default"; + pinctrl-0 = <&gpio_key_default>; + + key-volume-up { + label = "Volume Up"; + gpios = <&tlmm 85 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + debounce-interval = <15>; + }; + }; + + reserved-memory { + qseecom_mem: qseecom@84a00000 { + reg = <0x0 0x84a00000 0x0 0x1900000>; + no-map; + }; + + ramoops@8ee00000 { + compatible = "ramoops"; + reg = <0x0 0x8ee00000 0x0 0x80000>; + console-size = <0x40000>; + ftrace-size = <0x15000>; + record-size = <0x5000>; + pmsg-size = <0x2000>; + }; + }; + + vph_pwr: vph-pwr-regulator { + compatible = "regulator-fixed"; + regulator-name = "vph_pwr"; + regulator-always-on; + regulator-boot-on; + }; +}; + +&hsusb_phy { + vdd-supply = <&pm8953_l3>; + vdda-pll-supply = <&pm8953_l7>; + vdda-phy-dpdm-supply = <&pm8953_l13>; + + status = "okay"; +}; + +&pm8953_resin { + linux,code = <KEY_VOLUMEDOWN>; + status = "okay"; +}; + +&rpm_requests { + regulators { + compatible = "qcom,rpm-pm8953-regulators"; + vdd_s1-supply = <&vph_pwr>; + vdd_s2-supply = <&vph_pwr>; + vdd_s3-supply = <&vph_pwr>; + vdd_s4-supply = <&vph_pwr>; + vdd_s5-supply = <&vph_pwr>; + vdd_s6-supply = <&vph_pwr>; + vdd_s7-supply = <&vph_pwr>; + vdd_l1-supply = <&pm8953_s3>; + vdd_l2_l3-supply = <&pm8953_s3>; + vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>; + vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>; + vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>; + + pm8953_s1: s1 { + regulator-min-microvolt = <863000>; + regulator-max-microvolt = <1152000>; + }; + + pm8953_s3: s3 { + regulator-min-microvolt = <1224000>; + regulator-max-microvolt = <1224000>; + }; + + pm8953_s4: s4 { + regulator-min-microvolt = <1896000>; + regulator-max-microvolt = <2048000>; + }; + + pm8953_l1: l1 { + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1100000>; + }; + + pm8953_l2: l2 { + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + }; + + pm8953_l3: l3 { + regulator-min-microvolt = <925000>; + regulator-max-microvolt = <925000>; + regulator-allow-set-load; + }; + + pm8953_l5: l5 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8953_l6: l6 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8953_l7: l7 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1900000>; + }; + + pm8953_l8: l8 { + regulator-min-microvolt = <2900000>; + regulator-max-microvolt = <2900000>; + }; + + pm8953_l9: l9 { + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3300000>; + }; + + pm8953_l10: l10 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8953_l11: l11 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <3000000>; + }; + + pm8953_l12: l12 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3000000>; + }; + + pm8953_l13: l13 { + regulator-min-microvolt = <3075000>; + regulator-max-microvolt = <3125000>; + }; + + pm8953_l15: l15 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8953_l16: l16 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8953_l17: l17 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <3000000>; + }; + + pm8953_l19: l19 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1350000>; + }; + + pm8953_l22: l22 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2850000>; + }; + + pm8953_l23: l23 { + regulator-min-microvolt = <975000>; + regulator-max-microvolt = <1225000>; + }; + }; +}; + +&sdhc_1 { + vmmc-supply = <&pm8953_l8>; + vqmmc-supply = <&pm8953_l5>; + + status = "okay"; +}; + +&sdhc_2 { + vmmc-supply = <&pm8953_l11>; + vqmmc-supply = <&pm8953_l12>; + + cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; + + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_off>; + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; + + status = "okay"; +}; + +&tlmm { + gpio-reserved-ranges = <0 4>, <135 4>; +}; + +&usb3 { + status = "okay"; +}; + +&usb3_dwc3 { + dr_mode = "peripheral"; +}; + +&wcnss { + vddpx-supply = <&pm8953_l5>; + + status = "okay"; +}; + +&wcnss_iris { + compatible = "qcom,wcn3660b"; + + vddxo-supply = <&pm8953_l7>; + vddrfa-supply = <&pm8953_l19>; + vddpa-supply = <&pm8953_l9>; + vdddig-supply = <&pm8953_l5>; +};
Lenovo P2 is a handset using the MSM8953 SoC released in 2016 Add a device tree for with initial support for: - GPIO keys - SDHCI (internal and external storage) - USB Device Mode - WCNSS (WiFi/BT) - Regulators Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com> --- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++ 2 files changed, 241 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts