| Message ID | 20240327-sy7802-v1-1-db74ab32faaf@apitzsch.eu (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add sy7802 flash led driver | expand |
On Wed, 27 Mar 2024 23:51:33 +0100, André Apitzsch wrote: > Document Silergy SY7802 flash LED driver devicetree bindings. > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > --- > .../devicetree/bindings/leds/silergy,sy7802.yaml | 96 ++++++++++++++++++++++ > 1 file changed, 96 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/leds/silergy,sy7802.example.dts:23.13-26: Warning (reg_format): /example-0/flash-led-controller@53:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/leds/silergy,sy7802.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/silergy,sy7802.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/silergy,sy7802.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/silergy,sy7802.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/leds/silergy,sy7802.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240327-sy7802-v1-1-db74ab32faaf@apitzsch.eu The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Mar 27, 2024 at 11:51:33PM +0100, André Apitzsch wrote: > Document Silergy SY7802 flash LED driver devicetree bindings. > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > --- > .../devicetree/bindings/leds/silergy,sy7802.yaml | 96 ++++++++++++++++++++++ > 1 file changed, 96 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/silergy,sy7802.yaml b/Documentation/devicetree/bindings/leds/silergy,sy7802.yaml > new file mode 100644 > index 000000000000..d32efac8baa6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/silergy,sy7802.yaml > @@ -0,0 +1,96 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/silergy,sy7802.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Silergy SY7802 1800mA Boost Charge Pump LED Driver > + > +maintainers: > + - André Apitzsch <git@apitzsch.eu> > + > +description: | > + The SY7802 is a current-regulated charge pump which can regulate two current > + levels for Flash and Torch modes. > + > + The SY7802 is a high-current synchronous boost converter with 2-channel > + high side current sources. Each channel is able to deliver 900mA current. > + > +properties: > + compatible: > + enum: > + - silergy,sy7802 > + > + reg: > + maxItems: 1 > + > + enable-gpios: > + maxItems: 1 > + description: A connection to the 'EN' pin. > + > + flash-gpios: > + maxItems: 1 > + description: A connection to the 'FLEN' pin. > + > + vin-supply: > + description: Regulator providing power to the 'VIN' pin. > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^led@[0-1]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + description: Index of the LED. > + minimum: 0 > + maximum: 1 > + > + led-sources: > + allOf: Don't need allOf here. > + - minItems: 1 > + maxItems: 2 > + items: > + minimum: 0 > + maximum: 1 > + > + required: > + - reg > + - led-sources > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - enable-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/leds/common.h> > + > + flash-led-controller@53 { This needs to go under an appropriate bus node to fix the errors. i2c presumably. > + compatible = "silergy,sy7802"; > + reg = <0x53>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; > + > + led@0 { > + reg = <0>; > + function = LED_FUNCTION_FLASH; > + color = <LED_COLOR_ID_WHITE>; > + led-sources = <0>, <1>; > + }; > + }; > > -- > 2.44.0 >
diff --git a/Documentation/devicetree/bindings/leds/silergy,sy7802.yaml b/Documentation/devicetree/bindings/leds/silergy,sy7802.yaml new file mode 100644 index 000000000000..d32efac8baa6 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/silergy,sy7802.yaml @@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/silergy,sy7802.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Silergy SY7802 1800mA Boost Charge Pump LED Driver + +maintainers: + - André Apitzsch <git@apitzsch.eu> + +description: | + The SY7802 is a current-regulated charge pump which can regulate two current + levels for Flash and Torch modes. + + The SY7802 is a high-current synchronous boost converter with 2-channel + high side current sources. Each channel is able to deliver 900mA current. + +properties: + compatible: + enum: + - silergy,sy7802 + + reg: + maxItems: 1 + + enable-gpios: + maxItems: 1 + description: A connection to the 'EN' pin. + + flash-gpios: + maxItems: 1 + description: A connection to the 'FLEN' pin. + + vin-supply: + description: Regulator providing power to the 'VIN' pin. + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-1]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + description: Index of the LED. + minimum: 0 + maximum: 1 + + led-sources: + allOf: + - minItems: 1 + maxItems: 2 + items: + minimum: 0 + maximum: 1 + + required: + - reg + - led-sources + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - enable-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/leds/common.h> + + flash-led-controller@53 { + compatible = "silergy,sy7802"; + reg = <0x53>; + #address-cells = <1>; + #size-cells = <0>; + + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; + + led@0 { + reg = <0>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + led-sources = <0>, <1>; + }; + };