diff mbox series

gcc-plugins/stackleak: Avoid .head.text section

Message ID 20240328064256.2358634-2-ardb+git@google.com (mailing list archive)
State Mainlined
Commit e7d24c0aa8e678f41457d1304e2091cac6fd1a2e
Headers show
Series gcc-plugins/stackleak: Avoid .head.text section | expand

Commit Message

Ard Biesheuvel March 28, 2024, 6:42 a.m. UTC 
From: Ard Biesheuvel <ardb@kernel.org>

The .head.text section carries the startup code that runs with the MMU
off or with a translation of memory that deviates from the ordinary one.
So avoid instrumentation with the stackleak plugin, which already avoids
.init.text and .noinstr.text entirely.

Fixes: 48204aba801f1b51 ("x86/sme: Move early SME kernel encryption handling into .head.text")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202403221630.2692c998-oliver.sang@intel.com
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 scripts/gcc-plugins/stackleak_plugin.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kees Cook March 28, 2024, 9:56 p.m. UTC | #1 
On Thu, 28 Mar 2024 07:42:57 +0100, Ard Biesheuvel wrote:
> The .head.text section carries the startup code that runs with the MMU
> off or with a translation of memory that deviates from the ordinary one.
> So avoid instrumentation with the stackleak plugin, which already avoids
> .init.text and .noinstr.text entirely.
> 
> 

Applied to for-next/hardening, thanks!

[1/1] gcc-plugins/stackleak: Avoid .head.text section
      https://git.kernel.org/kees/c/4ac9a796ada0

Take care,
diff mbox series

Patch

diff --git a/scripts/gcc-plugins/stackleak_plugin.c b/scripts/gcc-plugins/stackleak_plugin.c
index c5c2ce113c92..d20c47d21ad8 100644
--- a/scripts/gcc-plugins/stackleak_plugin.c
+++ b/scripts/gcc-plugins/stackleak_plugin.c
@@ -467,6 +467,8 @@  static bool stackleak_gate(void)
 			return false;
 		if (STRING_EQUAL(section, ".entry.text"))
 			return false;
+		if (STRING_EQUAL(section, ".head.text"))
+			return false;
 	}
 
 	return track_frame_size >= 0;