Message ID | 20240423123302.1550592-2-amelie.delaunay@foss.st.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | Introduce STM32 DMA3 support | expand |
On Tue, 23 Apr 2024 14:32:51 +0200, Amelie Delaunay wrote: > Gather the STM32 DMA controllers bindings under ./dma/stm32/ > > Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com> > --- > .../devicetree/bindings/dma/{ => stm32}/st,stm32-dma.yaml | 4 ++-- > .../devicetree/bindings/dma/{ => stm32}/st,stm32-dmamux.yaml | 4 ++-- > .../devicetree/bindings/dma/{ => stm32}/st,stm32-mdma.yaml | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-dma.yaml (97%) > rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-dmamux.yaml (89%) > rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-mdma.yaml (96%) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/spi/st,stm32-spi.yaml references a file that doesn't exist: Documentation/devicetree/bindings/dma/st,stm32-dma.yaml Documentation/devicetree/bindings/spi/st,stm32-spi.yaml: Documentation/devicetree/bindings/dma/st,stm32-dma.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240423123302.1550592-2-amelie.delaunay@foss.st.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Rob, On 4/23/24 15:50, Rob Herring wrote: > > On Tue, 23 Apr 2024 14:32:51 +0200, Amelie Delaunay wrote: >> Gather the STM32 DMA controllers bindings under ./dma/stm32/ >> >> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com> >> --- >> .../devicetree/bindings/dma/{ => stm32}/st,stm32-dma.yaml | 4 ++-- >> .../devicetree/bindings/dma/{ => stm32}/st,stm32-dmamux.yaml | 4 ++-- >> .../devicetree/bindings/dma/{ => stm32}/st,stm32-mdma.yaml | 4 ++-- >> 3 files changed, 6 insertions(+), 6 deletions(-) >> rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-dma.yaml (97%) >> rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-dmamux.yaml (89%) >> rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-mdma.yaml (96%) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > > > doc reference errors (make refcheckdocs): > Warning: Documentation/devicetree/bindings/spi/st,stm32-spi.yaml references a file that doesn't exist: Documentation/devicetree/bindings/dma/st,stm32-dma.yaml > Documentation/devicetree/bindings/spi/st,stm32-spi.yaml: Documentation/devicetree/bindings/dma/st,stm32-dma.yaml > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240423123302.1550592-2-amelie.delaunay@foss.st.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Indeed. I'll wait for reviews of the whole series before sending a v2 fixing this warning. Regards, Amelie
diff --git a/Documentation/devicetree/bindings/dma/st,stm32-dma.yaml b/Documentation/devicetree/bindings/dma/stm32/st,stm32-dma.yaml similarity index 97% rename from Documentation/devicetree/bindings/dma/st,stm32-dma.yaml rename to Documentation/devicetree/bindings/dma/stm32/st,stm32-dma.yaml index 329847ef096a..071363d18443 100644 --- a/Documentation/devicetree/bindings/dma/st,stm32-dma.yaml +++ b/Documentation/devicetree/bindings/dma/stm32/st,stm32-dma.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/dma/st,stm32-dma.yaml# +$id: http://devicetree.org/schemas/dma/stm32/st,stm32-dma.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: STMicroelectronics STM32 DMA Controller @@ -53,7 +53,7 @@ maintainers: - Amelie Delaunay <amelie.delaunay@foss.st.com> allOf: - - $ref: dma-controller.yaml# + - $ref: /schemas/dma/dma-controller.yaml# properties: "#dma-cells": diff --git a/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml b/Documentation/devicetree/bindings/dma/stm32/st,stm32-dmamux.yaml similarity index 89% rename from Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml rename to Documentation/devicetree/bindings/dma/stm32/st,stm32-dmamux.yaml index e722fbcd8a5f..88c9e88cf3d5 100644 --- a/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml +++ b/Documentation/devicetree/bindings/dma/stm32/st,stm32-dmamux.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/dma/st,stm32-dmamux.yaml# +$id: http://devicetree.org/schemas/dma/stm32/st,stm32-dmamux.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: STMicroelectronics STM32 DMA MUX (DMA request router) @@ -10,7 +10,7 @@ maintainers: - Amelie Delaunay <amelie.delaunay@foss.st.com> allOf: - - $ref: dma-router.yaml# + - $ref: /schemas/dma/dma-router.yaml# properties: "#dma-cells": diff --git a/Documentation/devicetree/bindings/dma/st,stm32-mdma.yaml b/Documentation/devicetree/bindings/dma/stm32/st,stm32-mdma.yaml similarity index 96% rename from Documentation/devicetree/bindings/dma/st,stm32-mdma.yaml rename to Documentation/devicetree/bindings/dma/stm32/st,stm32-mdma.yaml index 3874544dfa74..45fe91db11db 100644 --- a/Documentation/devicetree/bindings/dma/st,stm32-mdma.yaml +++ b/Documentation/devicetree/bindings/dma/stm32/st,stm32-mdma.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/dma/st,stm32-mdma.yaml# +$id: http://devicetree.org/schemas/dma/stm32/st,stm32-mdma.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: STMicroelectronics STM32 MDMA Controller @@ -53,7 +53,7 @@ maintainers: - Amelie Delaunay <amelie.delaunay@foss.st.com> allOf: - - $ref: dma-controller.yaml# + - $ref: /schemas/dma/dma-controller.yaml# properties: "#dma-cells":
Gather the STM32 DMA controllers bindings under ./dma/stm32/ Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com> --- .../devicetree/bindings/dma/{ => stm32}/st,stm32-dma.yaml | 4 ++-- .../devicetree/bindings/dma/{ => stm32}/st,stm32-dmamux.yaml | 4 ++-- .../devicetree/bindings/dma/{ => stm32}/st,stm32-mdma.yaml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-dma.yaml (97%) rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-dmamux.yaml (89%) rename Documentation/devicetree/bindings/dma/{ => stm32}/st,stm32-mdma.yaml (96%)