| Message ID | 20240424162739.work.492-kees@kernel.org (mailing list archive) |
|---|---|
| State | In Next |
| Commit | c209826737b733b4ccd38448d7b025bb128aaa8a |
| Headers | show |
| Series | ubsan: Remove 1-element array usage in debug reporting | expand |
On 24/04/24 10:27, Kees Cook wrote: > The "type_name" character array was still marked as a 1-element array. > While we don't validate strings used in format arguments yet, let's fix > this before it causes trouble some future day. > > Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks! -- Gustavo > --- > Cc: Gustavo A. R. Silva <gustavoars@kernel.org> > Cc: Marco Elver <elver@google.com> > Cc: Andrey Konovalov <andreyknvl@gmail.com> > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > Cc: kasan-dev@googlegroups.com > Cc: linux-hardening@vger.kernel.org > --- > lib/ubsan.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ubsan.h b/lib/ubsan.h > index 0abbbac8700d..50ef50811b7c 100644 > --- a/lib/ubsan.h > +++ b/lib/ubsan.h > @@ -43,7 +43,7 @@ enum { > struct type_descriptor { > u16 type_kind; > u16 type_info; > - char type_name[1]; > + char type_name[]; > }; > > struct source_location {
diff --git a/lib/ubsan.h b/lib/ubsan.h index 0abbbac8700d..50ef50811b7c 100644 --- a/lib/ubsan.h +++ b/lib/ubsan.h @@ -43,7 +43,7 @@ enum { struct type_descriptor { u16 type_kind; u16 type_info; - char type_name[1]; + char type_name[]; }; struct source_location {
The "type_name" character array was still marked as a 1-element array. While we don't validate strings used in format arguments yet, let's fix this before it causes trouble some future day. Signed-off-by: Kees Cook <keescook@chromium.org> --- Cc: Gustavo A. R. Silva <gustavoars@kernel.org> Cc: Marco Elver <elver@google.com> Cc: Andrey Konovalov <andreyknvl@gmail.com> Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> Cc: kasan-dev@googlegroups.com Cc: linux-hardening@vger.kernel.org --- lib/ubsan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)