| Message ID | 20240514233747.work.441-kees@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 890a64810d59b1a58ed26efc28cfd821fc068e84 |
| Headers | show |
| Series | ubsan: Restore dependency on ARCH_HAS_UBSAN | expand |
On Wed, 15 May 2024 at 01:38, Kees Cook <keescook@chromium.org> wrote: > > While removing CONFIG_UBSAN_SANITIZE_ALL, ARCH_HAS_UBSAN wasn't correctly > depended on. Restore this, as we do not want to attempt UBSAN builds > unless it's actually been tested on a given architecture. > > Reported-by: Masahiro Yamada <masahiroy@kernel.org> > Closes: https://lore.kernel.org/all/20240514095427.541201-1-masahiroy@kernel.org > Fixes: 918327e9b7ff ("ubsan: Remove CONFIG_UBSAN_SANITIZE_ALL") > Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Marco Elver <elver@google.com> > --- > Cc: Marco Elver <elver@google.com> > Cc: Andrey Konovalov <andreyknvl@gmail.com> > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > Cc: kasan-dev@googlegroups.com > Cc: linux-hardening@vger.kernel.org > --- > lib/Kconfig.ubsan | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan > index e81e1ac4a919..bdda600f8dfb 100644 > --- a/lib/Kconfig.ubsan > +++ b/lib/Kconfig.ubsan > @@ -4,6 +4,7 @@ config ARCH_HAS_UBSAN > > menuconfig UBSAN > bool "Undefined behaviour sanity checker" > + depends on ARCH_HAS_UBSAN > help > This option enables the Undefined Behaviour sanity checker. > Compile-time instrumentation is used to detect various undefined > -- > 2.34.1 >
diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan index e81e1ac4a919..bdda600f8dfb 100644 --- a/lib/Kconfig.ubsan +++ b/lib/Kconfig.ubsan @@ -4,6 +4,7 @@ config ARCH_HAS_UBSAN menuconfig UBSAN bool "Undefined behaviour sanity checker" + depends on ARCH_HAS_UBSAN help This option enables the Undefined Behaviour sanity checker. Compile-time instrumentation is used to detect various undefined
While removing CONFIG_UBSAN_SANITIZE_ALL, ARCH_HAS_UBSAN wasn't correctly depended on. Restore this, as we do not want to attempt UBSAN builds unless it's actually been tested on a given architecture. Reported-by: Masahiro Yamada <masahiroy@kernel.org> Closes: https://lore.kernel.org/all/20240514095427.541201-1-masahiroy@kernel.org Fixes: 918327e9b7ff ("ubsan: Remove CONFIG_UBSAN_SANITIZE_ALL") Signed-off-by: Kees Cook <keescook@chromium.org> --- Cc: Marco Elver <elver@google.com> Cc: Andrey Konovalov <andreyknvl@gmail.com> Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> Cc: kasan-dev@googlegroups.com Cc: linux-hardening@vger.kernel.org --- lib/Kconfig.ubsan | 1 + 1 file changed, 1 insertion(+)