diff mbox series

[-next,v2,3/9] coccinelle: Add rules to find str_hi{gh}_lo{w}() replacements

Message ID 20240904091451.3328272-4-lihongbo22@huawei.com (mailing list archive)
State Superseded
Headers show
Series coccinelle: Add some rules for string_chioces helpers. | expand

Commit Message

Hongbo Li Sept. 4, 2024, 9:14 a.m. UTC 
As other rules done, we add rules for str_hi{gh}_lo{w}()
to check the relative opportunities.

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
 scripts/coccinelle/api/string_choices.cocci | 46 +++++++++++++++++++++
 1 file changed, 46 insertions(+)
diff mbox series

Patch

diff --git a/scripts/coccinelle/api/string_choices.cocci b/scripts/coccinelle/api/string_choices.cocci
index a1141bd29b3c..67818cd6ee09 100644
--- a/scripts/coccinelle/api/string_choices.cocci
+++ b/scripts/coccinelle/api/string_choices.cocci
@@ -131,3 +131,49 @@  e << str_false_true_r.E;
 @@
 
 coccilib.report.print_report(p[0], "opportunity for str_false_true(%s)" % e)
+
+@str_hi_lo depends on patch@
+expression E;
+@@
+(
+-      ((E) ? "hi" : "lo")
++      str_hi_lo(E)
+)
+
+@str_hi_lo_r depends on !patch exists@
+expression E;
+position P;
+@@
+(
+*      ((E@P) ? "hi" : "lo")
+)
+
+@script:python depends on report@
+p << str_hi_lo_r.P;
+e << str_hi_lo_r.E;
+@@
+
+coccilib.report.print_report(p[0], "opportunity for str_hi_lo(%s)" % e)
+
+@str_high_low depends on patch@
+expression E;
+@@
+(
+-      ((E) ? "high" : "low")
++      str_high_low(E)
+)
+
+@str_high_low_r depends on !patch exists@
+expression E;
+position P;
+@@
+(
+*      ((E@P) ? "high" : "low")
+)
+
+@script:python depends on report@
+p << str_high_low_r.P;
+e << str_high_low_r.E;
+@@
+
+coccilib.report.print_report(p[0], "opportunity for str_high_low(%s)" % e)