[-next,v2,5/9] coccinelle: Add rules to find str_enable{d}_disable{d}() replacements

Commit Message

Hongbo Li Sept. 4, 2024, 9:14 a.m. UTC

As other rules done, we add rules for str_enable{d}_
disable{d}() to check the relative opportunities.

Signed-off-by: Hongbo Li <[e-mail]>
---
 scripts/coccinelle/api/string_choices.cocci | 46 +++++++++++++++++++++
 1 file changed, 46 insertions(+)

Patch

diff --git a/scripts/coccinelle/api/string_choices.cocci b/scripts/coccinelle/api/string_choices.cocci
index 53fd34a0fcb4..7400eafdf040 100644
--- a/scripts/coccinelle/api/string_choices.cocci
+++ b/scripts/coccinelle/api/string_choices.cocci
@@ -223,3 +223,49 @@  e << str_low_high_r.E;
 @@
 
 coccilib.report.print_report(p[0], "opportunity for str_low_high(%s)" % e)
+
+@str_enable_disable depends on patch@
+expression E;
+@@
+(
+-      ((E) ? "enable" : "disable")
++      str_enable_disable(E)
+)
+
+@str_enable_disable_r depends on !patch exists@
+expression E;
+position P;
+@@
+(
+*      ((E@P) ? "enable" : "disable")
+)
+
+@script:python depends on report@
+p << str_enable_disable_r.P;
+e << str_enable_disable_r.E;
+@@
+
+coccilib.report.print_report(p[0], "opportunity for str_enable_disable(%s)" % e)
+
+@str_enabled_disabled depends on patch@
+expression E;
+@@
+(
+-      ((E) ? "enabled" : "disabled")
++      str_enabled_disabled(E)
+)
+
+@str_enabled_disabled_r depends on !patch exists@
+expression E;
+position P;
+@@
+(
+*      ((E@P) ? "enabled" : "disabled")
+)
+
+@script:python depends on report@
+p << str_enabled_disabled_r.P;
+e << str_enabled_disabled_r.E;
+@@
+
+coccilib.report.print_report(p[0], "opportunity for str_enabled_disabled(%s)" % e)