| Message ID | 20240904091451.3328272-9-lihongbo22@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | coccinelle: Add some rules for string_chioces helpers. | expand |
diff --git a/scripts/coccinelle/api/string_choices.cocci b/scripts/coccinelle/api/string_choices.cocci index 3ef7309164f4..bb09076e5f58 100644 --- a/scripts/coccinelle/api/string_choices.cocci +++ b/scripts/coccinelle/api/string_choices.cocci @@ -315,3 +315,26 @@ e << str_write_read_r.E; @@ coccilib.report.print_report(p[0], "opportunity for str_write_read(%s)" % e) + +@str_on_off depends on patch@ +expression E; +@@ +( +- ((E) ? "on" : "off") ++ str_on_off(E) +) + +@str_on_off_r depends on !patch exists@ +expression E; +position P; +@@ +( +* ((E@P) ? "on" : "off") +) + +@script:python depends on report@ +p << str_on_off_r.P; +e << str_on_off_r.E; +@@ + +coccilib.report.print_report(p[0], "opportunity for str_on_off(%s)" % e)
As other rules done, we add rules for str_on_off() to check the relative opportunities. Signed-off-by: Hongbo Li <lihongbo22@huawei.com> --- scripts/coccinelle/api/string_choices.cocci | 23 +++++++++++++++++++++ 1 file changed, 23 insertions(+)