diff mbox series

[-next,v3,05/10] coccinelle: Add rules to find str_enable{d}_disable{d}() replacements

Message ID 20240911010927.741343-6-lihongbo22@huawei.com (mailing list archive)
State Mainlined
Commit dd2275d349c2f02ceb6cd37f89b8b9920c602488
Headers show
Series coccinelle: Add some rules for string_chioces helpers. | expand

Commit Message

Hongbo Li Sept. 11, 2024, 1:09 a.m. UTC
As other rules done, we add rules for str_enable{d}_
disable{d}() to check the relative opportunities.

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
 scripts/coccinelle/api/string_choices.cocci | 38 +++++++++++++++++++++
 1 file changed, 38 insertions(+)
diff mbox series

Patch

diff --git a/scripts/coccinelle/api/string_choices.cocci b/scripts/coccinelle/api/string_choices.cocci
index e91d4eb30161..bb6b851ee2aa 100644
--- a/scripts/coccinelle/api/string_choices.cocci
+++ b/scripts/coccinelle/api/string_choices.cocci
@@ -203,3 +203,41 @@  e << str_low_high_r.E;
 @@
 
 coccilib.report.print_report(p[0], "opportunity for str_low_high(%s)" % e)
+
+@str_enable_disable depends on patch@
+expression E;
+@@
+-      ((E) ? "enable" : "disable")
++      str_enable_disable(E)
+
+@str_enable_disable_r depends on !patch exists@
+expression E;
+position P;
+@@
+*      ((E@P) ? "enable" : "disable")
+
+@script:python depends on report@
+p << str_enable_disable_r.P;
+e << str_enable_disable_r.E;
+@@
+
+coccilib.report.print_report(p[0], "opportunity for str_enable_disable(%s)" % e)
+
+@str_enabled_disabled depends on patch@
+expression E;
+@@
+-      ((E) ? "enabled" : "disabled")
++      str_enabled_disabled(E)
+
+@str_enabled_disabled_r depends on !patch exists@
+expression E;
+position P;
+@@
+*      ((E@P) ? "enabled" : "disabled")
+
+@script:python depends on report@
+p << str_enabled_disabled_r.P;
+e << str_enabled_disabled_r.E;
+@@
+
+coccilib.report.print_report(p[0], "opportunity for str_enabled_disabled(%s)" % e)