From patchwork Wed Oct 2 01:21:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dr. David Alan Gilbert" X-Patchwork-Id: 13819203 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE0D79F5; Wed, 2 Oct 2024 01:21:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727832101; cv=none; b=CFKPVd6yF6+TGfOY5836l5N5LpDJ7Pt6/Tw9GtFTL2PdlaJcVmWAB5Nsx6+vojdjF6wvEegioAz+jeaCAFWauAhckeomIvqiKXy0lwXtxELsndMB3cuDOK3DWglV7Q2cIw7UzfjwsYChISS0/glcAc4kxXyJV/u1aWbKV0gfToI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727832101; c=relaxed/simple; bh=ZeDiSAlMFI87I2II6phS5X5zbrtXvhPobSWe1x2GlMU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aARxi+azVHsQ5vIjT0pBqtdXEsh59UQuA6matVWKPPdwE6AyGmBxNjz8DZOPDQiN7lbFwZ1bu3f0Do+0pJZbs5rOV9tVdrhaB/PX/yF3f4w8JpinL8KLxQyHSD7wlHgm6gBMLsouFg4KHXUVfMco+CzvVGaRa4PFaGhPCMYtqyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=GGqy4T3c; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="GGqy4T3c" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=YC4m7QeWPR16LSIizcp1WirzkjTJp7vocJmIsUva1E8=; b=GGqy4T3ceiQ/MJMe ZryLIes26KDKFmV2aQYBR4L2u00fEVrU4om9MpjzHpaCOU2OxVqOPaXijgStkv7EJhuWmqfrsOr1I zSo+/ct3wDyV7xjfrYorDXY3glnvAU78Q4cg1mdLBfD4NaFwVtjKNQS0DlzuzfuFPj7UT+eNcZxQ1 B1gL1vRydWsiFJcvjxM0FAFxIuy44+wys0jdCVfthmYdCYze0ZCbTrRhpeNlCvL4ub5OjpY/zf2AK t1GhzcsTAmGWPHXEmPf6Gs7St3r9DUKOjIEDyzTXdmo5581XmLybHtjbGeA5sb+1LtLYajULAg91R g8GgMHfA5WRjLS2AaQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1svo3S-008MJv-0d; Wed, 02 Oct 2024 01:21:26 +0000 From: linux@treblig.org To: kees@kernel.org, andy@kernel.org, akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org, linux@rasmusvillemoes.dk, senozhatsky@chromium.org Cc: linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH] printf: Remove unused 'bprintf' Date: Wed, 2 Oct 2024 02:21:25 +0100 Message-ID: <20241002012125.405368-1-linux@treblig.org> X-Mailer: git-send-email 2.46.2 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Dr. David Alan Gilbert" bprintf is unused. Remove it. It was added in commit 4370aa4aa753 ("vsprintf: add binary printf") but as far as I can see was never used, unlike the other two functions in that patch. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Andy Shevchenko --- include/linux/string.h | 1 - lib/vsprintf.c | 23 ----------------------- 2 files changed, 24 deletions(-) diff --git a/include/linux/string.h b/include/linux/string.h index 0dd27afcfaf7..493ac4862c77 100644 --- a/include/linux/string.h +++ b/include/linux/string.h @@ -335,7 +335,6 @@ int __sysfs_match_string(const char * const *array, size_t n, const char *s); #ifdef CONFIG_BINARY_PRINTF int vbin_printf(u32 *bin_buf, size_t size, const char *fmt, va_list args); int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf); -int bprintf(u32 *bin_buf, size_t size, const char *fmt, ...) __printf(3, 4); #endif extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos, diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 09f022ba1c05..d072cd59eb6a 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -3383,29 +3383,6 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf) } EXPORT_SYMBOL_GPL(bstr_printf); -/** - * bprintf - Parse a format string and place args' binary value in a buffer - * @bin_buf: The buffer to place args' binary value - * @size: The size of the buffer(by words(32bits), not characters) - * @fmt: The format string to use - * @...: Arguments for the format string - * - * The function returns the number of words(u32) written - * into @bin_buf. - */ -int bprintf(u32 *bin_buf, size_t size, const char *fmt, ...) -{ - va_list args; - int ret; - - va_start(args, fmt); - ret = vbin_printf(bin_buf, size, fmt, args); - va_end(args); - - return ret; -} -EXPORT_SYMBOL_GPL(bprintf); - #endif /* CONFIG_BINARY_PRINTF */ /**