| Message ID | 20250320164633.101331-3-wthai@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add device tree for Nvidia's GB200NVL BMC | expand |
Hi Willie, On Thu, 2025-03-20 at 16:46 +0000, Willie Thai wrote: > This patch adds a binding for GB200NVL BMC. > > The GB200NVL BMC is an Aspeed Ast2600 based BMC for Nvidia Blackwell > GB200NVL platform. > Reference to Ast2600 SOC [1]. > Reference to Blackwell GB200NVL Platform [2]. > > Co-developed-by: Mars Yang <maryang@nvidia.com> > Signed-off-by: Mars Yang <maryang@nvidia.com> > Link: https://www.aspeedtech.com/server_ast2600/ [1] > Link: > https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703 [2] > Signed-off-by: Willie Thai <wthai@nvidia.com> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > index 01333ac111fb..a3736f134130 100644 > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > @@ -98,6 +98,7 @@ properties: > - inventec,starscream-bmc > - inventec,transformer-bmc > - jabil,rbp-bmc > + - nvidia,gb200nvl-bmc > - qcom,dc-scm-v1-bmc > - quanta,s6q-bmc > - ufispace,ncplite-bmc Please order this patch first in your series, before the devicetree. Andrew
> Hi Willie, > > On Thu, 2025-03-20 at 16:46 +0000, Willie Thai wrote: >> This patch adds a binding for GB200NVL BMC. >> >> The GB200NVL BMC is an Aspeed Ast2600 based BMC for Nvidia Blackwell >> GB200NVL platform. >> Reference to Ast2600 SOC [1]. >> Reference to Blackwell GB200NVL Platform [2]. >> >> Co-developed-by: Mars Yang <maryang@nvidia.com> >> Signed-off-by: Mars Yang <maryang@nvidia.com> >> Link: https://www.aspeedtech.com/server_ast2600/ [1] >> Link: >> https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703 [2] >> Signed-off-by: Willie Thai <wthai@nvidia.com> >> --- >> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> index 01333ac111fb..a3736f134130 100644 >> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> @@ -98,6 +98,7 @@ properties: >> - inventec,starscream-bmc >> - inventec,transformer-bmc >> - jabil,rbp-bmc >> + - nvidia,gb200nvl-bmc >> - qcom,dc-scm-v1-bmc >> - quanta,s6q-bmc >> - ufispace,ncplite-bmc > > Please order this patch first in your series, before the devicetree. > > Andrew Thanks Andrew for the feedback, will order the patches in v4.
On Thu, Mar 20, 2025 at 04:46:33PM +0000, Willie Thai wrote: > This patch adds a binding for GB200NVL BMC. Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > The GB200NVL BMC is an Aspeed Ast2600 based BMC for Nvidia Blackwell GB200NVL platform. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Usually this is just one line. Commit msgs should be concise. "Add binding for foo bar, an baz based board for making frubies". Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 01333ac111fb..a3736f134130 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -98,6 +98,7 @@ properties: - inventec,starscream-bmc - inventec,transformer-bmc - jabil,rbp-bmc + - nvidia,gb200nvl-bmc - qcom,dc-scm-v1-bmc - quanta,s6q-bmc - ufispace,ncplite-bmc