From patchwork Wed Oct 26 07:01:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Reshetova, Elena" X-Patchwork-Id: 9396107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ADA5060236 for ; Wed, 26 Oct 2016 07:04:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7796829891 for ; Wed, 26 Oct 2016 07:04:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6C67329895; Wed, 26 Oct 2016 07:04:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.wl.linuxfoundation.org (Postfix) with SMTP id 0D76A29891 for ; Wed, 26 Oct 2016 07:04:07 +0000 (UTC) Received: (qmail 32009 invoked by uid 550); 26 Oct 2016 07:04:06 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: kernel-hardening@lists.openwall.com Delivered-To: mailing list kernel-hardening@lists.openwall.com Received: (qmail 31966 invoked from network); 26 Oct 2016 07:04:04 -0000 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,549,1473145200"; d="scan'208";a="777813690" From: "Reshetova, Elena" To: Colin Vidal , Hans Liljestrand CC: "kernel-hardening@lists.openwall.com" Thread-Topic: fix typo __atomic_op_fence Thread-Index: AQHSLvcHwfuQTqUCh0+5i1eo9kgCuaC6T2uQ Date: Wed, 26 Oct 2016 07:01:23 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B41BF8BBA@IRSMSX102.ger.corp.intel.com> References: <1477424149.2263.52.camel@cvidal.org> In-Reply-To: <1477424149.2263.52.camel@cvidal.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] MIME-Version: 1.0 Subject: [kernel-hardening] RE: fix typo __atomic_op_fence X-Virus-Scanned: ClamAV using ClamSMTP Hi Colin, Sorry for the trouble. I have just applied the fix and pushed the update to the repo. Best Regards, Elena. -----Original Message----- From: Colin Vidal [mailto:colin@cvidal.org] Sent: Tuesday, October 25, 2016 10:36 PM To: Reshetova, Elena ; Hans Liljestrand Cc: kernel-hardening@lists.openwall.com Subject: fix typo __atomic_op_fence Hi Hans, can you apply this little fix on the commit b5cafefa6ec2dd549174edc8fbd678c06fcb0472 you have just pushed on Elena's hardened_atomic_on_next ? Otherwise, any build that use atomic_xchg_relaxed and atomic_cmpxchg_relaxed is broken. Thanks :) Colin diff --git a/include/linux/atomic.h b/include/linux/atomic.h index 4e9972d..ffd2e33 100644 --- a/include/linux/atomic.h +++ b/include/linux/atomic.h @@ -427,7 +427,7 @@    #ifndef atomic_xchg_wrap  #define  atomic_xchg_wrap(...)                         \ -       _atomic_op_fence(atomic_xchg_wrap, __VA_ARGS__) +       __atomic_op_fence(atomic_xchg_wrap, __VA_ARGS__)  #endif  #endif /* atomic_xchg_relaxed */   @@ -456,7 +456,7 @@    #ifndef atomic_cmpxchg_wrap  #define  atomic_cmpxchg_wrap(...)                              \ -       _atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__) +       __atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)  #endif  #endif /* atomic_cmpxchg_relaxed */