| Message ID | CAPDLWs-BFQ+NF15ntxFNS4MT2kVs+k9BUYreDZeYEP1sFLQJ+w@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Dec 04, 2017 at 10:51:53AM +0530, Kaiwan N Billimoria wrote: > > On Mon, Dec 4, 2017 at 10:25 AM, Tobin C. Harding <me@tobin.cc> wrote: > >> > >> > With the 'eval', no warning, it's fine. > >> > >> Why not use hex()? > > > >> > > >> > foreach my $config_file (@config_files) { > >> > + $config_file =~ s/\R*//g; > >> > >> Is there some reason you don't use chomp()? > > > > Wrt your suggestions: > > --- > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl > index 9906dcf8b807..260b52e456f1 100755 > --- a/scripts/leaking_addresses.pl > +++ b/scripts/leaking_addresses.pl > @@ -266,7 +266,7 @@ sub is_false_positive > sub is_false_positive_ix86_32 > { > my ($match) = @_; > - state $page_offset = eval get_page_offset(); # only gets called once > + state $page_offset = hex get_page_offset(); # only gets called once I don't think this is valid ;) I meant use hex() to convert the string to an int so it doesn't throw the warning (inside get_page_offset()). thanks, Tobin.
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index 9906dcf8b807..260b52e456f1 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -266,7 +266,7 @@ sub is_false_positive sub is_false_positive_ix86_32 { my ($match) = @_; - state $page_offset = eval get_page_offset(); # only gets called once + state $page_offset = hex get_page_offset(); # only gets called once if ($match =~ '\b(0x)?(f|F){8}\b') { return 1; @@ -313,7 +313,7 @@ sub get_page_offset } foreach my $config_file (@config_files) { - $config_file =~ s/\R*//g; + chomp $config_file; $page_offset = parse_kernel_config_file($config_file); if ($page_offset ne "") { return $page_offset;