| Message ID | TYSPR04MB70840448562705C21BA8DCCF8A632@TYSPR04MB7084.apcprd04.prod.outlook.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | clocksource/drivers/timer-sprd: Select driver on ARM and ARM64 | expand |
On 2024/9/19 15:25, Enlin Mu wrote: > From: Enlin Mu <enlin.mu@unisoc.com> > > sprd timer is currently available on ARM and ARM64 based devices. > Thus select it for ARM and ARM64 > > Signed-off-by: Enlin Mu <enlin.mu@unisoc.com> > --- > drivers/clocksource/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 95dd4660b5b6..296c5f664583 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -494,8 +494,8 @@ config MTK_CPUX_TIMER > config SPRD_TIMER > bool "Spreadtrum timer driver" if EXPERT > depends on HAS_IOMEM > - depends on (ARCH_SPRD || COMPILE_TEST) > - default ARCH_SPRD > + depends on (ARM || ARM64 || COMPILE_TEST) I don't understand, if this driver is available on ARM, why ARCH_SPRD is not enabled on ARM architecture? > + default y > select TIMER_OF > help > Enables support for the Spreadtrum timer driver.
On Thu, 19 Sept 2024 at 15:51, Baolin Wang <baolin.wang@linux.alibaba.com> wrote: > > > > On 2024/9/19 15:25, Enlin Mu wrote: > > From: Enlin Mu <enlin.mu@unisoc.com> > > > > sprd timer is currently available on ARM and ARM64 based devices. > > Thus select it for ARM and ARM64 > > > > Signed-off-by: Enlin Mu <enlin.mu@unisoc.com> > > --- > > drivers/clocksource/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > index 95dd4660b5b6..296c5f664583 100644 > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -494,8 +494,8 @@ config MTK_CPUX_TIMER > > config SPRD_TIMER > > bool "Spreadtrum timer driver" if EXPERT > > depends on HAS_IOMEM > > - depends on (ARCH_SPRD || COMPILE_TEST) > > - default ARCH_SPRD > > + depends on (ARM || ARM64 || COMPILE_TEST) > > I don't understand, if this driver is available on ARM, why ARCH_SPRD is > not enabled on ARM architecture? It is probably because GKI doesn't select ARCH_SPRD. > > > + default y > > select TIMER_OF > > help > > Enables support for the Spreadtrum timer driver.
Chunyan Zhang <zhang.lyra@gmail.com> 于2024年9月20日周五 09:48写道： > > On Thu, 19 Sept 2024 at 15:51, Baolin Wang > <baolin.wang@linux.alibaba.com> wrote: > > > > > > > > On 2024/9/19 15:25, Enlin Mu wrote: > > > From: Enlin Mu <enlin.mu@unisoc.com> > > > > > > sprd timer is currently available on ARM and ARM64 based devices. > > > Thus select it for ARM and ARM64 > > > > > > Signed-off-by: Enlin Mu <enlin.mu@unisoc.com> > > > --- > > > drivers/clocksource/Kconfig | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > > index 95dd4660b5b6..296c5f664583 100644 > > > --- a/drivers/clocksource/Kconfig > > > +++ b/drivers/clocksource/Kconfig > > > @@ -494,8 +494,8 @@ config MTK_CPUX_TIMER > > > config SPRD_TIMER > > > bool "Spreadtrum timer driver" if EXPERT > > > depends on HAS_IOMEM > > > - depends on (ARCH_SPRD || COMPILE_TEST) > > > - default ARCH_SPRD > > > + depends on (ARM || ARM64 || COMPILE_TEST) > > > > I don't understand, if this driver is available on ARM, why ARCH_SPRD is > > not enabled on ARM architecture? the ARCH_SPRD is not enabled on ARM by default for some other configs will enabled at same time. we just need the SPRD_TIMER > > It is probably because GKI doesn't select ARCH_SPRD. > > > > > > > + default y > > > select TIMER_OF > > > help > > > Enables support for the Spreadtrum timer driver. >
On 19/09/2024 09:25, Enlin Mu wrote: > From: Enlin Mu <enlin.mu@unisoc.com> > > sprd timer is currently available on ARM and ARM64 based devices. > Thus select it for ARM and ARM64 Can you answer Baolin's question ? Or can you tell what is the rational behind this change ?
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 95dd4660b5b6..296c5f664583 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -494,8 +494,8 @@ config MTK_CPUX_TIMER config SPRD_TIMER bool "Spreadtrum timer driver" if EXPERT depends on HAS_IOMEM - depends on (ARCH_SPRD || COMPILE_TEST) - default ARCH_SPRD + depends on (ARM || ARM64 || COMPILE_TEST) + default y select TIMER_OF help Enables support for the Spreadtrum timer driver.