From patchwork Tue May 30 21:30:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 13261169 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93164C77B7A for ; Tue, 30 May 2023 21:29:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232009AbjE3V3b (ORCPT ); Tue, 30 May 2023 17:29:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjE3V3b (ORCPT ); Tue, 30 May 2023 17:29:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E968C7; Tue, 30 May 2023 14:29:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CFCB662F3A; Tue, 30 May 2023 21:29:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58FF0C433EF; Tue, 30 May 2023 21:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685482169; bh=GLu5O3LRK+uO/mUwyhrjlKostu2tteVX5Bk4Ufg7ekc=; h=Date:From:To:Cc:Subject:From; b=ZNQPtKFdt5D+x3VhvyKmUos4cGo3u6phr45fOBLBoMRuPKE7fdH8G8pMi346ZzBBY mhK8Dz5AzQ4T0CJ36AlrlvO1syDAE8qb2tZ/gou9OJeW5yru/5SI0KLTHGjYKPwn42 XtxYYduapa1Z8trkQLBBuE5HC/+kxbdm9twKTe0/iX+JdFpo4fEioJmTtNpszyvoTd fTMn8yT3wl/G26qYclsyYVotsP6DeAR4tgW5kChJEPEeco45QA33ZzcIEPTQTLD5dq osA99hB+fW5P+RWmtgA+rdLREk5oxm8PQ/Cyssv9eJMYH/NXdXxjtSrpKwRdGwRYbb lYCvJBoSDjzFQ== Date: Tue, 30 May 2023 15:30:20 -0600 From: "Gustavo A. R. Silva" To: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH][next] scsi: lpfc: Avoid -Wstringop-overflow warning Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Avoid confusing the compiler about possible negative sizes. Use size_t instead of int for variables size and copied. Address the following warning found with GCC-13: In function ‘lpfc_debugfs_ras_log_data’, inlined from ‘lpfc_debugfs_ras_log_open’ at drivers/scsi/lpfc/lpfc_debugfs.c:2271:15: drivers/scsi/lpfc/lpfc_debugfs.c:2210:25: warning: ‘memcpy’ specified bound between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=] 2210 | memcpy(buffer + copied, dmabuf->virt, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2211 | size - copied - 1); | ~~~~~~~~~~~~~~~~~~ Link: https://github.com/KSPP/linux/issues/305 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/lpfc/lpfc_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index bdf34af4ef36..493729e74abe 100644 --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -2189,9 +2189,9 @@ lpfc_debugfs_lockstat_write(struct file *file, const char __user *buf, #endif static int lpfc_debugfs_ras_log_data(struct lpfc_hba *phba, - char *buffer, int size) + char *buffer, size_t size) { - int copied = 0; + size_t copied = 0; struct lpfc_dmabuf *dmabuf, *next; memset(buffer, 0, size); @@ -2249,7 +2249,7 @@ lpfc_debugfs_ras_log_open(struct inode *inode, struct file *file) { struct lpfc_hba *phba = inode->i_private; struct lpfc_debug *debug; - int size; + size_t size; int rc = -ENOMEM; spin_lock_irq(&phba->hbalock);