From patchwork Wed Feb 28 06:22:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prasad Pandit X-Patchwork-Id: 10246861 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7135860362 for ; Wed, 28 Feb 2018 06:23:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 62FFE289F5 for ; Wed, 28 Feb 2018 06:23:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 57A9228A25; Wed, 28 Feb 2018 06:23:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.wl.linuxfoundation.org (Postfix) with SMTP id 2F1B7289F5 for ; Wed, 28 Feb 2018 06:23:20 +0000 (UTC) Received: (qmail 32714 invoked by uid 550); 28 Feb 2018 06:23:19 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Delivered-To: mailing list kernel-hardening@lists.openwall.com Received: (qmail 32691 invoked from network); 28 Feb 2018 06:23:18 -0000 Date: Wed, 28 Feb 2018 11:52:58 +0530 (IST) From: P J P X-X-Sender: pjp@javelin To: Kees Cook cc: Laura Abbott , Kernel Hardening , Florian Weimer Subject: Re: [PATCH 0/1] Zero initialise kernel stack variables In-Reply-To: Message-ID: References: <20180227111532.1144-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 28 Feb 2018 06:23:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 28 Feb 2018 06:23:06 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ppandit@redhat.com' RCPT:'' X-Virus-Scanned: ClamAV using ClamSMTP +-- On Tue, 27 Feb 2018, Kees Cook wrote --+ | On Tue, Feb 27, 2018 at 3:26 PM, Laura Abbott wrote: | > For comparison (-300 is official Fedora, -301 is from the repo): | > | > text data bss dec hex filename | > 16948437 6771094 1777872 25497403 1850f3b /lib/debug/lib/modules/4.15.5-300.fc27.x86_64/vmlinux | > 16970359 6776078 1777872 25524309 1857855 /lib/debug/lib/modules/4.15.5-301.fc27.x86_64/vmlinux | | That's a surprisingly small text change! I'd love to see benchmarks | too. Are you able to verify this is initializing the | passed-by-reference variables too? Hmm, I suspect it's time for | another LKDTM test. ;) It could be because I had to build Crypt target support(CONFIG_DM_CRYPT=y) into kernel. It would not boot without it, not sure why. F27 -300 kernel does boot with DM_CRYPT as module. === Thank you. --- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F === $ diff -Naurp config-4.15.5-300.fc27.x86_64 config-4.15.5-301.fc27.x86_64 --- config-4.15.5-300.fc27.x86_64 2018-02-28 11:49:52.248210900 +0530 +++ config-4.15.5-301.fc27.x86_64 2018-02-28 11:50:35.448957090 +0530 @@ -1,6 +1,6 @@ # # Automatically generated file; DO NOT EDIT. -# Linux/x86_64 4.15.5-300.fc27.x86_64 Kernel Configuration +# Linux/x86_64 4.15.5-301.fc27.x86_64 Kernel Configuration # CONFIG_64BIT=y CONFIG_X86_64=y @@ -2394,7 +2394,7 @@ CONFIG_DM_DEBUG_BLOCK_MANAGER_LOCKING=y # CONFIG_DM_DEBUG_BLOCK_STACK_TRACING is not set CONFIG_DM_BIO_PRISON=m CONFIG_DM_PERSISTENT_DATA=m -CONFIG_DM_CRYPT=m +CONFIG_DM_CRYPT=y CONFIG_DM_SNAPSHOT=y CONFIG_DM_THIN_PROVISIONING=m CONFIG_DM_CACHE=m @@ -7612,6 +7612,7 @@ CONFIG_DEBUG_INFO=y CONFIG_DEBUG_INFO_VTA=y # CONFIG_GDB_SCRIPTS is not set # CONFIG_ENABLE_WARN_DEPRECATED is not set +CONFIG_FINIT_LOCAL_VARS=y CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=2048 CONFIG_STRIP_ASM_SYMS=y