mbox series

[0/1] Fix swapped coeffs for LM5066 and LM5066i iin

Message ID 20190128170034.24348-1-wilburm@gmail.com (mailing list archive)
Headers show
Series Fix swapped coeffs for LM5066 and LM5066i iin | expand

Message

Matt Wilbur Jan. 28, 2019, 5 p.m. UTC
For the LM5066,

For CL=GND,  50 mV threshold && DEVICE_SETUP[4] == 0
For CL=VDD, 26 mV threshold && DEVICE_SETUP[4] == 1

(from Section 8.3.1 and Table 31 of current datasheet)

And from Table 43 (I have reversed the rows of the datasheet to stay
consistent with your ordering):

CL = GND: m = 5405, b =-600, R - 2
CL = VDD:  m = 10753, b = -1200, R = -2

Combining the two statements:
DEVICE_SETUP[4] == 0: m = 5405, b =-600, R - 2
DEVICE_SETUP[4] == 1: m = 10753, b = -1200, R = -2

According to current code (again reversing the order to be consistent
with the above):

DEVICE_SETUP[4] == 0: use coeff[PSC_CURRENT_IN]
DEVICE_SETUP[4] == 1: use coeff[PSC_CURRENT_IN_L]

And for the lm5066 coefficient:

        [PSC_CURRENT_IN] = {
            .m = 10753,
            .R = -2,
        },
        [PSC_CURRENT_IN_L] = {
            .m = 5405,
            .R = -2,
        },

Again, combing the two:

DEVICE_SETUP[4] == 0: m = 10753, b = 0, R = -2
DEVICE_SETUP[4] == 1: m = 5405, b = 0, R = -2

which which is the opposite of the device datasheet (which I copy and
paste here):

DEVICE_SETUP[4] == 0: m = 5405, b =-600, R - 2
DEVICE_SETUP[4] == 1: m = 10753, b = -1200, R = -2


Matt Wilbur (1):
  Fix swapped coeffs for LM5066 and LM5066i iin

 drivers/hwmon/pmbus/lm25066.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)