mbox series

[0/3] hwmon: (lm85) add LM96000 high freqency pwm support

Message ID 20190129212920.27921-1-jgebben@sweptlaser.com (mailing list archive)
Headers show
Series hwmon: (lm85) add LM96000 high freqency pwm support | expand

Message

Jeremy Gebben Jan. 29, 2019, 9:29 p.m. UTC 
Hi,

This patch adds support for the PWM frequencies from 22.5 to 30 kHz
available on the LM96000.

It looks like this chip has been supported for a long time, but wasn't
mentioned in the docs (which I have updated).

Also, it has been using the generic 'lm85' prefix, which I have not
changed to avoid breaking userspace or device tree files. AFAICT,
lm85_detect() will only return 'lm85' for LM96000 chips, so it doesn't
look like you can get a bare 'lm85' prefix with any other chips.

I stumbled on to a 10 year old thread discussing a patch which looks
like an early attempt to add support for this chip, which may be of
interest:
https://lm-sensors.lm-sensors.narkive.com/1SIwaMDT/patch-hwmon-lm96000-support

Thanks for reviewing,

Jeremy


Jeremy Gebben (3):
  hwmon: (lm85) remove freq_map size hardcodes
  hwmon: (lm85) Document the LM96000 as supported
  hwmon: (lm85) add support for LM96000 high frequencies

 Documentation/hwmon/lm85 |  9 ++++++++-
 drivers/hwmon/lm85.c     | 32 ++++++++++++++++++++++----------
 2 files changed, 30 insertions(+), 11 deletions(-)

Comments

Guenter Roeck Jan. 29, 2019, 11:38 p.m. UTC | #1 
On Tue, Jan 29, 2019 at 02:29:17PM -0700, Jeremy Gebben wrote:
> Hi,
> 
> This patch adds support for the PWM frequencies from 22.5 to 30 kHz
> available on the LM96000.
> 
> It looks like this chip has been supported for a long time, but wasn't
> mentioned in the docs (which I have updated).
> 
> Also, it has been using the generic 'lm85' prefix, which I have not
> changed to avoid breaking userspace or device tree files. AFAICT,
> lm85_detect() will only return 'lm85' for LM96000 chips, so it doesn't
> look like you can get a bare 'lm85' prefix with any other chips.
> 
> I stumbled on to a 10 year old thread discussing a patch which looks
> like an early attempt to add support for this chip, which may be of
> interest:
> https://lm-sensors.lm-sensors.narkive.com/1SIwaMDT/patch-hwmon-lm96000-support
> 
> Thanks for reviewing,
> 
Where are the actual patches ?

Guenter
Jeremy Gebben Jan. 30, 2019, 4:19 p.m. UTC | #2 
On Tue, Jan 29, 2019 at 4:38 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Tue, Jan 29, 2019 at 02:29:17PM -0700, Jeremy Gebben wrote:
> > Hi,
> >
> > This patch adds support for the PWM frequencies from 22.5 to 30 kHz
> > available on the LM96000.
> >
> > It looks like this chip has been supported for a long time, but wasn't
> > mentioned in the docs (which I have updated).
> >
> > Also, it has been using the generic 'lm85' prefix, which I have not
> > changed to avoid breaking userspace or device tree files. AFAICT,
> > lm85_detect() will only return 'lm85' for LM96000 chips, so it doesn't
> > look like you can get a bare 'lm85' prefix with any other chips.
> >
> > I stumbled on to a 10 year old thread discussing a patch which looks
> > like an early attempt to add support for this chip, which may be of
> > interest:
> > https://lm-sensors.lm-sensors.narkive.com/1SIwaMDT/patch-hwmon-lm96000-support
> >
> > Thanks for reviewing,
> >
> Where are the actual patches ?

Oops! It looks like they didn't send correctly. Hopefully they should
be showing up shortly.

Jeremy

>
> Guenter